mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: i.MX6: fix usdhc3 pinmuxing on tqma6x
@ 2017-06-23 15:09 Michael Tretter
  2017-06-27  6:34 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Tretter @ 2017-06-23 15:09 UTC (permalink / raw)
  To: barebox; +Cc: Michael Tretter

The usdhc3 pin group wrongly referred the SD4 pads instead of the SD3 pads.
This leads to issues when muxing the SD4_CMD and SD4_CLK pads for uart3.

This regression was introduced by code refactoring in commit a5207a6 ("ARM:
dts: i.MX6: drop usage of pin group defines").

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/dts/imx6qdl-tqma6x.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/dts/imx6qdl-tqma6x.dtsi b/arch/arm/dts/imx6qdl-tqma6x.dtsi
index f0b1a0db7..82f9ec368 100644
--- a/arch/arm/dts/imx6qdl-tqma6x.dtsi
+++ b/arch/arm/dts/imx6qdl-tqma6x.dtsi
@@ -76,12 +76,12 @@
 
 		pinctrl_usdhc3: usdhc3grp {
 			fsl,pins = <
-				MX6QDL_PAD_SD4_CMD__SD4_CMD		0x17059
-				MX6QDL_PAD_SD4_CLK__SD4_CLK		0x10059
-				MX6QDL_PAD_SD4_DAT0__SD4_DATA0		0x17059
-				MX6QDL_PAD_SD4_DAT1__SD4_DATA1		0x17059
-				MX6QDL_PAD_SD4_DAT2__SD4_DATA2		0x17059
-				MX6QDL_PAD_SD4_DAT3__SD4_DATA3		0x17059
+				MX6QDL_PAD_SD3_CMD__SD3_CMD		0x17059
+				MX6QDL_PAD_SD3_CLK__SD3_CLK		0x10059
+				MX6QDL_PAD_SD3_DAT0__SD3_DATA0		0x17059
+				MX6QDL_PAD_SD3_DAT1__SD3_DATA1		0x17059
+				MX6QDL_PAD_SD3_DAT2__SD3_DATA2		0x17059
+				MX6QDL_PAD_SD3_DAT3__SD3_DATA3		0x17059
 				MX6QDL_PAD_SD3_DAT4__SD3_DATA4		0x17059
 				MX6QDL_PAD_SD3_DAT5__SD3_DATA5		0x17059
 				MX6QDL_PAD_SD3_DAT6__SD3_DATA6		0x17059
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: i.MX6: fix usdhc3 pinmuxing on tqma6x
  2017-06-23 15:09 [PATCH] ARM: dts: i.MX6: fix usdhc3 pinmuxing on tqma6x Michael Tretter
@ 2017-06-27  6:34 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-06-27  6:34 UTC (permalink / raw)
  To: Michael Tretter; +Cc: barebox

On Fri, Jun 23, 2017 at 05:09:50PM +0200, Michael Tretter wrote:
> The usdhc3 pin group wrongly referred the SD4 pads instead of the SD3 pads.
> This leads to issues when muxing the SD4_CMD and SD4_CLK pads for uart3.
> 
> This regression was introduced by code refactoring in commit a5207a6 ("ARM:
> dts: i.MX6: drop usage of pin group defines").
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>  arch/arm/dts/imx6qdl-tqma6x.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/dts/imx6qdl-tqma6x.dtsi b/arch/arm/dts/imx6qdl-tqma6x.dtsi
> index f0b1a0db7..82f9ec368 100644
> --- a/arch/arm/dts/imx6qdl-tqma6x.dtsi
> +++ b/arch/arm/dts/imx6qdl-tqma6x.dtsi
> @@ -76,12 +76,12 @@
>  
>  		pinctrl_usdhc3: usdhc3grp {
>  			fsl,pins = <
> -				MX6QDL_PAD_SD4_CMD__SD4_CMD		0x17059
> -				MX6QDL_PAD_SD4_CLK__SD4_CLK		0x10059
> -				MX6QDL_PAD_SD4_DAT0__SD4_DATA0		0x17059
> -				MX6QDL_PAD_SD4_DAT1__SD4_DATA1		0x17059
> -				MX6QDL_PAD_SD4_DAT2__SD4_DATA2		0x17059
> -				MX6QDL_PAD_SD4_DAT3__SD4_DATA3		0x17059
> +				MX6QDL_PAD_SD3_CMD__SD3_CMD		0x17059
> +				MX6QDL_PAD_SD3_CLK__SD3_CLK		0x10059
> +				MX6QDL_PAD_SD3_DAT0__SD3_DATA0		0x17059
> +				MX6QDL_PAD_SD3_DAT1__SD3_DATA1		0x17059
> +				MX6QDL_PAD_SD3_DAT2__SD3_DATA2		0x17059
> +				MX6QDL_PAD_SD3_DAT3__SD3_DATA3		0x17059
>  				MX6QDL_PAD_SD3_DAT4__SD3_DATA4		0x17059
>  				MX6QDL_PAD_SD3_DAT5__SD3_DATA5		0x17059
>  				MX6QDL_PAD_SD3_DAT6__SD3_DATA6		0x17059
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-27  6:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 15:09 [PATCH] ARM: dts: i.MX6: fix usdhc3 pinmuxing on tqma6x Michael Tretter
2017-06-27  6:34 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox