From: Michael Olbrich <m.olbrich@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 2/8] common: efi: do not use undefined kconfig option
Date: Thu, 6 Jul 2017 09:31:16 +0200 [thread overview]
Message-ID: <20170706073116.jkfwdmxibbgopmmz@pengutronix.de> (raw)
In-Reply-To: <1499252725.22075.6.camel@pengutronix.de>
On Wed, Jul 05, 2017 at 01:05:25PM +0200, Lucas Stach wrote:
> Am Mittwoch, den 05.07.2017, 12:56 +0200 schrieb Steffen Trumtrar:
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > common/efi/efi.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/common/efi/efi.c b/common/efi/efi.c
> > index 05c58250f4a7..f924385958e1 100644
> > --- a/common/efi/efi.c
> > +++ b/common/efi/efi.c
> > @@ -266,8 +266,7 @@ static int efi_console_init(void)
> >
> > add_generic_device("efi-stdio", DEVICE_ID_SINGLE, NULL, 0 , 0, 0, NULL);
> >
> > - if (IS_ENABLED(CONFIG_ARCH_EFI_REGISTER_COM1))
>
> It seems we lost this option when moving arch/efi to arch/x86. As
> unconditionally enabling the serial console may break some boards, the
> proper fix should be to bring back the Kconfig option.
I think that option is pretty much redundant. This is x86. There is no
device tree to enable devices.
There are only two possible scenarios: use ns16550 or not. Building the
driver and maybe use it does not exist. And we can use
CONFIG_DRIVER_SERIAL_NS16550 to choose.
Somewhat unrelated: I think this driver should be avoided if possible. I'm
quite certain, that the original use-case for this was a bug in barebox and
not a broken EFI serial driver.
Michael
> > - add_ns16550_device(0, 0x3f8, 0x10, IORESOURCE_IO | IORESOURCE_MEM_8BIT,
> > + add_ns16550_device(0, 0x3f8, 0x10, IORESOURCE_IO | IORESOURCE_MEM_8BIT,
> > &ns16550_plat);
> >
> > return 0;
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-07-06 7:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 10:56 [PATCH 1/8] state: fix compile warnings for dev_err expansion Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 2/8] common: efi: do not use undefined kconfig option Steffen Trumtrar
2017-07-05 11:05 ` Lucas Stach
2017-07-06 7:31 ` Michael Olbrich [this message]
2017-07-05 10:56 ` [PATCH 3/8] fs: efi: return with correct error code in efifs_stat Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 4/8] devfs-core: add function to find cdev by partuuid Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 5/8] of: of_path: find device via partuuid Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 6/8] efi: efi: load state from devicetree Steffen Trumtrar
2017-07-05 12:38 ` Lucas Stach
2017-07-05 10:56 ` [PATCH 7/8] blspec: skip all devicetree tests if entry doesn't specify one Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 8/8] efi: efi: register barebox-update handler Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706073116.jkfwdmxibbgopmmz@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox