From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1db6Vo-0003Qt-Hz for barebox@lists.infradead.org; Fri, 28 Jul 2017 14:45:17 +0000 Received: by mail-pg0-x241.google.com with SMTP id v190so23824610pgv.1 for ; Fri, 28 Jul 2017 07:44:48 -0700 (PDT) From: Andrey Smirnov Date: Fri, 28 Jul 2017 07:44:17 -0700 Message-Id: <20170728144427.14007-2-andrew.smirnov@gmail.com> In-Reply-To: <20170728144427.14007-1-andrew.smirnov@gmail.com> References: <20170728144427.14007-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v3 01/11] gpiolib: Fix buggy flag detection code To: barebox@lists.infradead.org Cc: Andrey Smirnov Both GPIOF_ACTIVE_LOW and GPIOF_INIT_ACTIVE are multi-bit constants so detecting their assertion using simple bit-wise and is incorrect and would lead to false positives. Fixes: bbc499914 ("gpiolib: Add code to support "active low" GPIOs") Acked-by: Sam Ravnborg Signed-off-by: Andrey Smirnov --- drivers/gpio/gpiolib.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1a373ef14..d081e02fd 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -120,24 +120,31 @@ int gpio_request_one(unsigned gpio, unsigned long flags, const char *label) { int err; + /* + * Not all of the flags below are mulit-bit, but, for the sake + * of consistency, the code is written as if all of them were. + */ + const bool active_low = (flags & GPIOF_ACTIVE_LOW) == GPIOF_ACTIVE_LOW; + const bool dir_in = (flags & GPIOF_DIR_IN) == GPIOF_DIR_IN; + const bool logical = (flags & GPIOF_LOGICAL) == GPIOF_LOGICAL; + const bool init_active = (flags & GPIOF_INIT_ACTIVE) == GPIOF_INIT_ACTIVE; + const bool init_high = (flags & GPIOF_INIT_HIGH) == GPIOF_INIT_HIGH; + err = gpio_request(gpio, label); if (err) return err; - if (flags & GPIOF_ACTIVE_LOW) { + if (active_low) { struct gpio_info *gi = gpio_to_desc(gpio); gi->active_low = true; } - if (flags & GPIOF_DIR_IN) { + if (dir_in) err = gpio_direction_input(gpio); - } else if (flags & GPIOF_LOGICAL) { - err = gpio_direction_active(gpio, - !!(flags & GPIOF_INIT_ACTIVE)); - } else { - err = gpio_direction_output(gpio, - !!(flags & GPIOF_INIT_HIGH)); - } + else if (logical) + err = gpio_direction_active(gpio, init_active); + else + err = gpio_direction_output(gpio, init_high); if (err) goto free_gpio; -- 2.13.3 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox