From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] ARM: i.MX7: Warp7: Add some code comments
Date: Fri, 28 Jul 2017 22:21:30 +0200 [thread overview]
Message-ID: <20170728202130.3891-1-u.kleine-koenig@pengutronix.de> (raw)
This makes it easier to understand what is done and adapt this code for
other boards. My editor also added a newline at eof which is good.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boards/element14-warp7/lowlevel.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boards/element14-warp7/lowlevel.c b/arch/arm/boards/element14-warp7/lowlevel.c
index 38b7745f64ea..89a77d2f88ea 100644
--- a/arch/arm/boards/element14-warp7/lowlevel.c
+++ b/arch/arm/boards/element14-warp7/lowlevel.c
@@ -17,10 +17,16 @@ static noinline void warp7_start(void)
void __iomem *ccmbase = IOMEM(MX7_CCM_BASE_ADDR);
void *fdt;
+ /* CCM_CCGR148_CLR, uart1 */
writel(0x3, ccmbase + 0x4000 + 16 * 148 + 0x8);
+ /* CCM_TARGET_ROOT95 = UART1_CLK_ROOT */
writel(0x10000000, ccmbase + 0x8000 + 128 * 95);
+ /* CCM_CCGR148_SET, uart1 */
writel(0x3, ccmbase + 0x4000 + 16 * 148 + 0x4);
+
+ /* MX7D_PAD_UART1_RX_DATA__UART1_DCE_RX without daisy chaining */
writel(0x0, iomuxbase + 0x128);
+ /* MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX */
writel(0x0, iomuxbase + 0x12c);
imx7_uart_setup(uart);
@@ -45,4 +51,4 @@ ENTRY_FUNCTION(start_imx7s_element14_warp7, r0, r1, r2)
barrier();
warp7_start();
-}
\ No newline at end of file
+}
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2017-07-28 20:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728202130.3891-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox