mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
Date: Wed, 2 Aug 2017 14:25:12 +0200	[thread overview]
Message-ID: <20170802122512.GA16652@ravnborg.org> (raw)
In-Reply-To: <20170802070356.8185-1-antonynpavlov@gmail.com>

Hi Antony.

On Wed, Aug 02, 2017 at 10:03:56AM +0300, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/gpio/gpio-clps711x.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
> index d71c606690..e97f468e82 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -74,6 +74,9 @@ out_err:
>  
>  static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
>  	{ .compatible = "cirrus,clps711x-gpio", },
> +	{
> +		/* sentinel */
> +	}
nitpick.

Please follow the style of the line above - so like this:

	{ /* sentinel */ },
};

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-08-02 12:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02  7:03 Antony Pavlov
2017-08-02 12:25 ` Sam Ravnborg [this message]
2017-08-04 13:10   ` [PATCH v2] " Antony Pavlov
2017-09-05  7:26     ` Antony Pavlov
2017-09-06 12:38     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802122512.GA16652@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox