mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
@ 2017-08-02  7:03 Antony Pavlov
  2017-08-02 12:25 ` Sam Ravnborg
  0 siblings, 1 reply; 5+ messages in thread
From: Antony Pavlov @ 2017-08-02  7:03 UTC (permalink / raw)
  To: barebox

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/gpio/gpio-clps711x.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index d71c606690..e97f468e82 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -74,6 +74,9 @@ out_err:
 
 static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
 	{ .compatible = "cirrus,clps711x-gpio", },
+	{
+		/* sentinel */
+	}
 };
 
 static struct driver_d clps711x_gpio_driver = {
-- 
2.13.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
  2017-08-02  7:03 [PATCH] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry Antony Pavlov
@ 2017-08-02 12:25 ` Sam Ravnborg
  2017-08-04 13:10   ` [PATCH v2] " Antony Pavlov
  0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2017-08-02 12:25 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox

Hi Antony.

On Wed, Aug 02, 2017 at 10:03:56AM +0300, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/gpio/gpio-clps711x.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
> index d71c606690..e97f468e82 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -74,6 +74,9 @@ out_err:
>  
>  static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
>  	{ .compatible = "cirrus,clps711x-gpio", },
> +	{
> +		/* sentinel */
> +	}
nitpick.

Please follow the style of the line above - so like this:

	{ /* sentinel */ },
};

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
  2017-08-02 12:25 ` Sam Ravnborg
@ 2017-08-04 13:10   ` Antony Pavlov
  2017-09-05  7:26     ` Antony Pavlov
  2017-09-06 12:38     ` Sascha Hauer
  0 siblings, 2 replies; 5+ messages in thread
From: Antony Pavlov @ 2017-08-04 13:10 UTC (permalink / raw)
  To: barebox; +Cc: Sam Ravnborg

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alexander Shiyan <shc_work@mail.ru>
---

Changes since v1:

  * change formatting

 drivers/gpio/gpio-clps711x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index d71c606690..769e6ca4f7 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -74,6 +74,7 @@ out_err:
 
 static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
 	{ .compatible = "cirrus,clps711x-gpio", },
+	{ /* sentinel */ }
 };
 
 static struct driver_d clps711x_gpio_driver = {
-- 
2.13.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
  2017-08-04 13:10   ` [PATCH v2] " Antony Pavlov
@ 2017-09-05  7:26     ` Antony Pavlov
  2017-09-06 12:38     ` Sascha Hauer
  1 sibling, 0 replies; 5+ messages in thread
From: Antony Pavlov @ 2017-09-05  7:26 UTC (permalink / raw)
  To: Sascha Hauer, Lucas Stach; +Cc: barebox

On Fri,  4 Aug 2017 16:10:45 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:

I can't find this patch neither in the master branch nor in the next branch
of the pengutronix public repo.

Please apply it!

> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> ---
> 
> Changes since v1:
> 
>   * change formatting
> 
>  drivers/gpio/gpio-clps711x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
> index d71c606690..769e6ca4f7 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -74,6 +74,7 @@ out_err:
>  
>  static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
>  	{ .compatible = "cirrus,clps711x-gpio", },
> +	{ /* sentinel */ }
>  };
>  
>  static struct driver_d clps711x_gpio_driver = {
> -- 
> 2.13.3
> 


-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry
  2017-08-04 13:10   ` [PATCH v2] " Antony Pavlov
  2017-09-05  7:26     ` Antony Pavlov
@ 2017-09-06 12:38     ` Sascha Hauer
  1 sibling, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2017-09-06 12:38 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox, Sam Ravnborg

On Fri, Aug 04, 2017 at 04:10:45PM +0300, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> ---
> 
> Changes since v1:
> 
>   * change formatting
> 
>  drivers/gpio/gpio-clps711x.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
> index d71c606690..769e6ca4f7 100644
> --- a/drivers/gpio/gpio-clps711x.c
> +++ b/drivers/gpio/gpio-clps711x.c
> @@ -74,6 +74,7 @@ out_err:
>  
>  static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
>  	{ .compatible = "cirrus,clps711x-gpio", },
> +	{ /* sentinel */ }
>  };
>  
>  static struct driver_d clps711x_gpio_driver = {
> -- 
> 2.13.3
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-09-06 12:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02  7:03 [PATCH] gpio: clps711x: clps711x_gpio_dt_ids: add missing sentinel entry Antony Pavlov
2017-08-02 12:25 ` Sam Ravnborg
2017-08-04 13:10   ` [PATCH v2] " Antony Pavlov
2017-09-05  7:26     ` Antony Pavlov
2017-09-06 12:38     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox