From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] spi: imx: don't loop endlessly
Date: Wed, 2 Aug 2017 22:19:23 +0200 [thread overview]
Message-ID: <20170802201923.yq34mtr25ki3j25c@pengutronix.de> (raw)
In-Reply-To: <20170802195440.GA12893@ravnborg.org>
On Wed, Aug 02, 2017 at 09:54:40PM +0200, Sam Ravnborg wrote:
> Hi Uwe.
>
> On Wed, Aug 02, 2017 at 09:39:05PM +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > during bringup of an i.MX7 board I am faced with cspi_2_3_xchg_single not
> > returning. I don't know yet why this happens, but with this patch set it at least
> > doesn't block barebox.
>
> Your description reminded me of a similar issue we hit with SPI transfer.
> Back then Sascha fixed it but with some open question marks.
>
> See 9da7e18573c725eaa6123c401df57d6a4f6a0ea2
> ("spi: i.MX: reset controller on init")
>
> But as this is the latest patch to the imx_spi.c file you likely
> have already looked at it.
I havn't looked at it, but it is included in my barebox as I'm using
2017.08.0 + some patches.
Reading through the patch description, it doesn't match my situation.
I'm doing USB-Booting because when I made eMMC work all my available
remote hands already called it a day. So unless the boot ROM does
something strange (impossible!) barebox is the first spi user.
What seems to be similar is that TESTREG.TXCNT is != 0. For me this
smells clk-related. On i.MX6 I recently identified a problem (but didn't
come around yet to mainline a fix) that might match at least your
problem.
Can you still reproduce? How does your clk-tree look like (clk_dump)?
Thanks for your attention
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-08-02 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 19:39 Uwe Kleine-König
2017-08-02 19:39 ` [PATCH 1/2] spi: imx: add error checking Uwe Kleine-König
2017-08-02 19:39 ` [PATCH 2/2] spi: imx: add timeout to xchg_single Uwe Kleine-König
2017-08-02 19:54 ` [PATCH 0/2] spi: imx: don't loop endlessly Sam Ravnborg
2017-08-02 20:19 ` Uwe Kleine-König [this message]
2017-08-02 20:32 ` Sam Ravnborg
2017-08-03 9:07 ` Uwe Kleine-König
2017-08-03 10:43 ` Sam Ravnborg
2017-08-03 18:41 ` Uwe Kleine-König
2017-09-29 18:08 ` Alexander Kurz
2017-10-02 5:31 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170802201923.yq34mtr25ki3j25c@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox