From: Antony Pavlov <antonynpavlov@gmail.com>
To: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
Cc: barebox@lists.infradead.org, Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH 0/2] readline_simple: return -1 if getc fails
Date: Thu, 10 Aug 2017 08:51:46 +0300 [thread overview]
Message-ID: <20170810085146.f7d28709750f2181bad6e45c@gmail.com> (raw)
In-Reply-To: <20170809185853.lvlar7vyder6supt@gportay>
On Wed, 9 Aug 2017 14:58:53 -0400
Gaël PORTAY <gael.portay@savoirfairelinux.com> wrote:
> Hi,
>
> On Wed, Aug 09, 2017 at 08:05:57AM +0200, Oleksij Rempel wrote:
> > Am 09.08.2017 um 06:13 schrieb Gaël PORTAY:
> > > Dear maintainers,
> > >
> > > I came accross this issue when I was trying to add support for a new MIPS
> > > board.
> >
> > Just out of curiosity, what MIPS board are you working on? If it is not
> > a secret :)
> >
>
> I am working on VoCore2[1]; it is a board based on a mediatek mt7628 CPU.
>
> I am doing this to learn myself how works barebox
Please see this branch for mt7628:
https://github.com/frantony/barebox/tree/20160815.mediatek
>
> Offtopic: For now it is booting on a really really old version of u-boot. I am
> able de boot barebox from u-boot. I had to hack the mips_disable_interrupts to
> remove the reset of flag ERL in CP0; but I don't know why yet. This flag is
> supposed to be set when CPU reboots; but because I am running barebox from a the
> command go of u-boot, this flag is unset.
>
> Are you able to re-run barebox from barebox on your MIPS board?
>
> .macro mips_disable_interrupts
> .set push
> .set noreorder
> mfc0 k0, CP0_STATUS
> - li k1, ~(ST0_ERL | ST0_IE)
> + li k1, ~ST0_IE
> and k0, k1
> mtc0 k0, CP0_STATUS
> .set pop
> .endm
>
> For now, I have splitted mips_disable_interrupts into two macros. The second
> macro mips_reset_error_level checks if the ERL flag is armed before resetting it
> to 0.
>
> .macro mips_reset_error_level
> .set push
> .set noreorder
> mfc0 k0, CP0_STATUS
> li k1, ST0_ERL
> and k1, k0
> bne k1, zero, 1f
> li k1, ~(ST0_ERL)
> and k0, k1
> mtc0 k0, CP0_STATUS
> 1: .set pop
> .endm
>
> But I don't know if this is the right thing to do.
>
> [1]: https://www.indiegogo.com/projects/vocore2-4-coin-sized-linux-computer-with-wifi#/
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-08-10 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 4:13 Gaël PORTAY
2017-08-09 4:13 ` [PATCH v2 1/2] " Gaël PORTAY
2017-08-09 4:13 ` [PATCH v2 2/2] readline_simple: remove obsolete documentation Gaël PORTAY
2017-08-09 6:05 ` [PATCH 0/2] readline_simple: return -1 if getc fails Oleksij Rempel
2017-08-09 18:58 ` Gaël PORTAY
2017-08-09 19:41 ` Oleksij Rempel
2017-08-10 5:51 ` Antony Pavlov [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-07 22:10 Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810085146.f7d28709750f2181bad6e45c@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=gael.portay@savoirfairelinux.com \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox