From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] state: provide an error message when an error occurs
Date: Thu, 17 Aug 2017 10:05:43 +0200 [thread overview]
Message-ID: <20170817080543.ul6ge4awubb6qbo2@pengutronix.de> (raw)
In-Reply-To: <20170816122709.23129-1-jbe@pengutronix.de>
Hallo Jürgen,
On Wed, Aug 16, 2017 at 02:27:07PM +0200, Juergen Borleis wrote:
> A simple typo makes the state framework fail, but without an error
> message the developer is lost in the dark.
>
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> ---
> common/state/state.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/state/state.c b/common/state/state.c
> index 121ba0c6d..fc822b21b 100644
> --- a/common/state/state.c
> +++ b/common/state/state.c
> @@ -240,6 +240,7 @@ static int state_convert_node_variable(struct state *state,
>
> vtype = state_find_type_by_name(type_name);
> if (!vtype) {
> + dev_dbg(&state->dev, "Error: invalid variable type '%s'\n", type_name);
I think this is only visible if you manually define DEBUG for state.
Assuming this is right dev_dbg doesn't match your intention.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-08-17 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 12:27 Juergen Borleis
2017-08-16 12:27 ` [PATCH 2/3] state command: extend help part I Juergen Borleis
2017-08-16 12:27 ` [PATCH 3/3] state command: extend help part II Juergen Borleis
2017-08-17 8:05 ` Uwe Kleine-König [this message]
2017-08-17 8:16 ` [PATCH 1/3] state: provide an error message when an error occurs Juergen Borleis
2017-09-06 12:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817080543.ul6ge4awubb6qbo2@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox