From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 1/3] state: provide an error message when an error occurs
Date: Thu, 17 Aug 2017 10:16:17 +0200 [thread overview]
Message-ID: <201708171016.17905.jbe@pengutronix.de> (raw)
In-Reply-To: <20170817080543.ul6ge4awubb6qbo2@pengutronix.de>
Hi Uwe,
On Thursday 17 August 2017 10:05:43 Uwe Kleine-König wrote:
> On Wed, Aug 16, 2017 at 02:27:07PM +0200, Juergen Borleis wrote:
> > A simple typo makes the state framework fail, but without an error
> > message the developer is lost in the dark.
> >
> > Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
> > ---
> > common/state/state.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/common/state/state.c b/common/state/state.c
> > index 121ba0c6d..fc822b21b 100644
> > --- a/common/state/state.c
> > +++ b/common/state/state.c
> > @@ -240,6 +240,7 @@ static int state_convert_node_variable(struct state
> > *state,
> >
> > vtype = state_find_type_by_name(type_name);
> > if (!vtype) {
> > + dev_dbg(&state->dev, "Error: invalid variable type '%s'\n", type_name);
>
> I think this is only visible if you manually define DEBUG for state.
> Assuming this is right dev_dbg doesn't match your intention.
My intention is to enlighten the developer when she/he adds the state feature
to her/his machine. Its not intended for the enduser (which means the
developer already has made a bad work). So the required "#define DEBUG" is
intended.
Jürgen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-08-17 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 12:27 Juergen Borleis
2017-08-16 12:27 ` [PATCH 2/3] state command: extend help part I Juergen Borleis
2017-08-16 12:27 ` [PATCH 3/3] state command: extend help part II Juergen Borleis
2017-08-17 8:05 ` [PATCH 1/3] state: provide an error message when an error occurs Uwe Kleine-König
2017-08-17 8:16 ` Juergen Borleis [this message]
2017-09-06 12:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201708171016.17905.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox