[PATCH] mtd: nand-mxs: improve error messages

[PATCH] mtd: nand-mxs: improve error messages

[Uwe Kleine-König]

This commit adds the return value of the failing function to one message
and makes the other unique.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mtd/nand/nand_mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
index bac5c4a47798..837bb23a606b 100644
--- a/drivers/mtd/nand/nand_mxs.c
+++ b/drivers/mtd/nand/nand_mxs.c
@@ -459,7 +459,7 @@ static void mxs_nand_cmd_ctrl(struct mtd_info *mtd, int data, unsigned int ctrl)
 	/* Execute the DMA chain. */
 	ret = mxs_dma_go(channel);
 	if (ret)
-		printf("MXS NAND: Error sending command\n");
+		printf("MXS NAND: Error sending command (%d)\n", ret);
 
 	mxs_nand_return_dma_descs(nand_info);
 
@@ -777,7 +777,7 @@ static int mxs_nand_ecc_read_page(struct mtd_info *mtd, struct nand_chip *nand,
 	/* Execute the DMA chain. */
 	ret = mxs_dma_go(channel);
 	if (ret) {
-		printf("MXS NAND: DMA read error\n");
+		printf("MXS NAND: DMA read error (ecc)\n");
 		goto rtn;
 	}
 
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mtd: nand-mxs: improve error messages

[Sascha Hauer]

On Thu, Aug 24, 2017 at 04:47:14PM +0200, Uwe Kleine-König wrote:
> This commit adds the return value of the failing function to one message
> and makes the other unique.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mtd/nand/nand_mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
> index bac5c4a47798..837bb23a606b 100644
> --- a/drivers/mtd/nand/nand_mxs.c
> +++ b/drivers/mtd/nand/nand_mxs.c
> @@ -459,7 +459,7 @@ static void mxs_nand_cmd_ctrl(struct mtd_info *mtd, int data, unsigned int ctrl)
>  	/* Execute the DMA chain. */
>  	ret = mxs_dma_go(channel);
>  	if (ret)
> -		printf("MXS NAND: Error sending command\n");
> +		printf("MXS NAND: Error sending command (%d)\n", ret);
>  
>  	mxs_nand_return_dma_descs(nand_info);
>  
> @@ -777,7 +777,7 @@ static int mxs_nand_ecc_read_page(struct mtd_info *mtd, struct nand_chip *nand,
>  	/* Execute the DMA chain. */
>  	ret = mxs_dma_go(channel);
>  	if (ret) {
> -		printf("MXS NAND: DMA read error\n");
> +		printf("MXS NAND: DMA read error (ecc)\n");
>  		goto rtn;
>  	}
>  
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox