From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] gpio: gpio-generic: fix bgpio_map()
Date: Wed, 6 Sep 2017 14:37:06 +0200 [thread overview]
Message-ID: <20170906123706.lcw6wsqjwhuv52tk@pengutronix.de> (raw)
In-Reply-To: <20170905072237.2268-2-antonynpavlov@gmail.com>
On Tue, Sep 05, 2017 at 10:22:36AM +0300, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/gpio/gpio-generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
> index c6202fc651..164aaed97a 100644
> --- a/drivers/gpio/gpio-generic.c
> +++ b/drivers/gpio/gpio-generic.c
> @@ -327,7 +327,7 @@ static void __iomem *bgpio_map(struct device_d *dev, const char *name,
> return NULL;
> }
>
> - return ret;
> + return IOMEM(r->start);
> }
This still looks wrong. We have:
void __iomem *ret;
...
ret = request_iomem_region(dev_name(dev), r->start, r->end);
request_iomem_region() returns a struct resource * from which you should
return the start element.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-09-06 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 7:22 [PATCH 0/2] gpio: gpio-generic: add dt support Antony Pavlov
2017-09-05 7:22 ` [PATCH 1/2] gpio: gpio-generic: fix bgpio_map() Antony Pavlov
2017-09-06 12:37 ` Sascha Hauer [this message]
2017-09-05 7:22 ` [PATCH 2/2] gpio: gpio-generic: add dt support Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906123706.lcw6wsqjwhuv52tk@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox