From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dpZaC-0006Lk-TG for barebox@lists.infradead.org; Wed, 06 Sep 2017 12:37:32 +0000 Date: Wed, 6 Sep 2017 14:37:06 +0200 From: Sascha Hauer Message-ID: <20170906123706.lcw6wsqjwhuv52tk@pengutronix.de> References: <20170905072237.2268-1-antonynpavlov@gmail.com> <20170905072237.2268-2-antonynpavlov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170905072237.2268-2-antonynpavlov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] gpio: gpio-generic: fix bgpio_map() To: Antony Pavlov Cc: barebox@lists.infradead.org On Tue, Sep 05, 2017 at 10:22:36AM +0300, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > drivers/gpio/gpio-generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c > index c6202fc651..164aaed97a 100644 > --- a/drivers/gpio/gpio-generic.c > +++ b/drivers/gpio/gpio-generic.c > @@ -327,7 +327,7 @@ static void __iomem *bgpio_map(struct device_d *dev, const char *name, > return NULL; > } > > - return ret; > + return IOMEM(r->start); > } This still looks wrong. We have: void __iomem *ret; ... ret = request_iomem_region(dev_name(dev), r->start, r->end); request_iomem_region() returns a struct resource * from which you should return the start element. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox