From: Enrico Jorns <ejo@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Enrico Jorns <ejo@pengutronix.de>
Subject: [PATCH 1/5] commands: nv: argc cannot be < 1
Date: Wed, 13 Sep 2017 14:23:28 +0200 [thread overview]
Message-ID: <20170913122332.17585-2-ejo@pengutronix.de> (raw)
In-Reply-To: <20170913122332.17585-1-ejo@pengutronix.de>
argc == 1 will only contain the name of the program itself which must be
present when invoking nv command code.
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
---
commands/nv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/commands/nv.c b/commands/nv.c
index 37cdb96647..eb396bfd9b 100644
--- a/commands/nv.c
+++ b/commands/nv.c
@@ -55,9 +55,6 @@ static int do_nv(int argc, char *argv[])
argc -= optind;
argv += optind;
- if (argc < 1)
- return COMMAND_ERROR_USAGE;
-
for (i = 0; i < argc; i++) {
value = strchr(argv[0], '=');
if (value) {
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-09-13 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 12:23 [PATCH 0/5] Fixes for nv command handling Enrico Jorns
2017-09-13 12:23 ` Enrico Jorns [this message]
2017-09-14 6:27 ` [PATCH 1/5] commands: nv: argc cannot be < 1 Sascha Hauer
2017-09-14 7:28 ` Enrico Joerns
2017-09-13 12:23 ` [PATCH 2/5] commands: nv: call nvvar_print() only if no argument is given Enrico Jorns
2017-09-13 12:23 ` [PATCH 3/5] commands: nv: assure error code will be returned when an error occurred Enrico Jorns
2017-09-13 12:23 ` [PATCH 4/5] commands: nv: fail if required var arguments are missing Enrico Jorns
2017-09-13 12:23 ` [PATCH 5/5] common: globvar: let nvvar_remove() report non-existing variable Enrico Jorns
2017-09-13 13:06 ` [PATCH] commands: nv: adjust command help Enrico Jorns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913122332.17585-2-ejo@pengutronix.de \
--to=ejo@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox