mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 05/12] mci: mmci: add DT support
Date: Sat, 16 Sep 2017 15:37:26 +0200	[thread overview]
Message-ID: <20170916133726.GB6457@ravnborg.org> (raw)
In-Reply-To: <20170915083922.25134-6-l.stach@pengutronix.de>

Hi Lucas.

On Fri, Sep 15, 2017 at 10:39:15AM +0200, Lucas Stach wrote:
> Just adds the minimal implementation to fill platform_data from
> the DT properties with Linux binding.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---


> @@ -625,7 +658,7 @@ static int mmci_probe(struct amba_device *dev, const struct amba_id *id)
>  	host->mci.max_req_size = (1 << variant->datalength_bits) - 1;
>  
>  	host->mci.host_caps = plat->capabilities;
> -	host->mci.voltages = plat->ocr_mask;
> +	host->mci.voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | plat->ocr_mask;

This change is not justified in the changelog?!?


	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-09-16 13:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15  8:39 [PATCH 00/12] Vexpress rework Lucas Stach
2017-09-15  8:39 ` [PATCH 01/12] ARM: vexpress: always build relocatable image Lucas Stach
2017-09-15  8:39 ` [PATCH 02/12] of: populate clock providers before other devices Lucas Stach
2017-09-15  8:39 ` [PATCH 03/12] clk: versatile: add basic clocks Lucas Stach
2017-09-16 13:34   ` Sam Ravnborg
2017-09-15  8:39 ` [PATCH 04/12] clocksource: sp804: silently ignore secondary instaces Lucas Stach
2017-09-15  8:39 ` [PATCH 05/12] mci: mmci: add DT support Lucas Stach
2017-09-16 13:37   ` Sam Ravnborg [this message]
2017-09-15  8:39 ` [PATCH 06/12] ARM: vexpress: switch to DT probe and multi-image build Lucas Stach
2017-09-15  8:39 ` [PATCH 07/12] ARM: vexpress: regenerate config Lucas Stach
2017-09-15  8:39 ` [PATCH 08/12] docs: add qemu vexpress Lucas Stach
2017-09-15  8:39 ` [PATCH 09/12] vexpress: use device tree provided by QEMU if available Lucas Stach
2017-09-15  8:39 ` [PATCH 10/12] vexpress: add bootstate node to the device tree Lucas Stach
2017-09-15  8:39 ` [PATCH 11/12] of: base: add funtion to copy a device tree node Lucas Stach
2017-09-20  6:20   ` Sascha Hauer
2017-09-15  8:39 ` [PATCH 12/12] ARM: vexpress: add fixup handler for 'virtio, mmio' devices Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170916133726.GB6457@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox