From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1duYQC-0000bk-Qz for barebox@lists.infradead.org; Wed, 20 Sep 2017 06:23:47 +0000 Date: Wed, 20 Sep 2017 08:23:22 +0200 From: Sascha Hauer Message-ID: <20170920062322.d2wsbg5saesspn72@pengutronix.de> References: <20170918122628.11477-1-s.trumtrar@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170918122628.11477-1-s.trumtrar@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] memtest: fix list iteration in region setup To: Steffen Trumtrar Cc: barebox@lists.infradead.org On Mon, Sep 18, 2017 at 02:26:28PM +0200, Steffen Trumtrar wrote: > When memory regions start at 0, the current mem_test_request_regions function > wrongly assumes that struct resource *r points at the correct region. It points > to the first region however (which starts at 0). > > The comment states, that the code starts from the second entry. > In include/linux/list.h the macro documentation however says: > > list_for_each_entry_from - iterate over list of given type from the current point > > The correct list iteration macro to use here is list_for_each_entry_continue, > where the documentation says: > > Continue to iterate over list of given type, continuing after > the current position. > > Signed-off-by: Steffen Trumtrar Applied, thanks Sascha > --- > common/memtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/memtest.c b/common/memtest.c > index 8af998e883e1..0fc20467580e 100644 > --- a/common/memtest.c > +++ b/common/memtest.c > @@ -90,7 +90,7 @@ int mem_test_request_regions(struct list_head *list) > * > * Between used regions. Start from second entry. > */ > - list_for_each_entry_from(r, &bank->res->children, sibling) { > + list_for_each_entry_continue(r, &bank->res->children, sibling) { > start = PAGE_ALIGN(r_prev->end + 1); > end = r->start - 1; > r_prev = r; > -- > 2.11.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox