[PATCH] ARM: i.MX53 QSB: drop phy reset handling in board file

[PATCH] ARM: i.MX53 QSB: drop phy reset handling in board file

[Uwe Kleine-König]

Since commit

	5c1846b62524 ("ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree")

the fec driver ensures a phy reset. As there is little use in resetting
twice, drop the reset from the board file.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boards/freescale-mx53-qsb/board.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/arch/arm/boards/freescale-mx53-qsb/board.c b/arch/arm/boards/freescale-mx53-qsb/board.c
index f75c9d12cd6b..0b1c927b81d4 100644
--- a/arch/arm/boards/freescale-mx53-qsb/board.c
+++ b/arch/arm/boards/freescale-mx53-qsb/board.c
@@ -64,15 +64,6 @@ static void set_board_rev(int rev)
 	loco_system_rev =  (loco_system_rev & ~(0xF << 8)) | (rev & 0xF) << 8;
 }
 
-#define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
-
-static void loco_fec_reset(void)
-{
-	gpio_direction_output(LOCO_FEC_PHY_RST, 0);
-	mdelay(1);
-	gpio_set_value(LOCO_FEC_PHY_RST, 1);
-}
-
 #define MX53_LOCO_USB_PWREN		IMX_GPIO_NR(7, 8)
 
 static int loco_late_init(void)
@@ -148,8 +139,6 @@ static int loco_late_init(void)
 	gpio_direction_output(MX53_LOCO_USB_PWREN, 0);
 	gpio_set_value(MX53_LOCO_USB_PWREN, 1);
 
-	loco_fec_reset();
-
 	set_silicon_rev(imx_silicon_revision());
 
 	armlinux_set_architecture(MACH_TYPE_MX53_LOCO);
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: i.MX53 QSB: drop phy reset handling in board file

[Sascha Hauer]

On Fri, Sep 22, 2017 at 11:54:59AM +0200, Uwe Kleine-König wrote:
> Since commit
> 
> 	5c1846b62524 ("ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree")
> 
> the fec driver ensures a phy reset. As there is little use in resetting
> twice, drop the reset from the board file.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boards/freescale-mx53-qsb/board.c | 11 -----------
>  1 file changed, 11 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/boards/freescale-mx53-qsb/board.c b/arch/arm/boards/freescale-mx53-qsb/board.c
> index f75c9d12cd6b..0b1c927b81d4 100644
> --- a/arch/arm/boards/freescale-mx53-qsb/board.c
> +++ b/arch/arm/boards/freescale-mx53-qsb/board.c
> @@ -64,15 +64,6 @@ static void set_board_rev(int rev)
>  	loco_system_rev =  (loco_system_rev & ~(0xF << 8)) | (rev & 0xF) << 8;
>  }
>  
> -#define LOCO_FEC_PHY_RST		IMX_GPIO_NR(7, 6)
> -
> -static void loco_fec_reset(void)
> -{
> -	gpio_direction_output(LOCO_FEC_PHY_RST, 0);
> -	mdelay(1);
> -	gpio_set_value(LOCO_FEC_PHY_RST, 1);
> -}
> -
>  #define MX53_LOCO_USB_PWREN		IMX_GPIO_NR(7, 8)
>  
>  static int loco_late_init(void)
> @@ -148,8 +139,6 @@ static int loco_late_init(void)
>  	gpio_direction_output(MX53_LOCO_USB_PWREN, 0);
>  	gpio_set_value(MX53_LOCO_USB_PWREN, 1);
>  
> -	loco_fec_reset();
> -
>  	set_silicon_rev(imx_silicon_revision());
>  
>  	armlinux_set_architecture(MACH_TYPE_MX53_LOCO);
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox