From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] i.MX6ull evk support
Date: Thu, 28 Sep 2017 12:13:45 +0200 [thread overview]
Message-ID: <20170928101345.ohpxhicbbmkvkmce@pengutronix.de> (raw)
In-Reply-To: <1506591212.2283.11.camel@pengutronix.de>
On Thu, Sep 28, 2017 at 11:33:32AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 28.09.2017, 11:26 +0200 schrieb Sascha Hauer:
> > On Thu, Sep 28, 2017 at 11:16:15AM +0200, Lucas Stach wrote:
> > > Am Mittwoch, den 27.09.2017, 14:16 +0200 schrieb Sascha Hauer:
> > > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-
> > > > imx/Kconfig
> > > > index 92440e3a75..dab19a33ec 100644
> > > > --- a/arch/arm/mach-imx/Kconfig
> > > > +++ b/arch/arm/mach-imx/Kconfig
> > > > @@ -162,6 +162,10 @@ config ARCH_IMX6UL
> > > > bool
> > > > select ARCH_IMX6
> > > >
> > > > +config ARCH_IMX6ULL
> > > > + bool
> > > > + select ARCH_IMX6
> > > > +
> > >
> > > Do we really need this? Seems the MX6ULL is just a stripped down
> > > version of the MX6UL.
> >
> > We probably do not need this, but I suggest to keep it anyway. I
> > think
> > it makes it a bit clearer that there are indeed i.MX6ul *and*
> > i.MX6ull
> > and both are supported.
>
> Yeah, your decision, but I'll notice that we don't have separate
> Kconfig symbols for MX6Q/DL, which probably expose more software
> visible differences than MX6UL/ULL.
While refactoring the patches I realized that having a i.MX6ull function
which just calls the corresponding i.MX6ul function doesn't look too
nice when additionally we have a board which either has one of both
SoCs calling the i.MX6ul version and needs a comment that this is the
same as the i.MX6ull variant.
I dropped the IMX6ULL symbol.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-09-28 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 12:16 [PATCH 1/2] ARM: i.MX6ull: Add SoC specific lowlevel_init function Sascha Hauer
2017-09-27 12:16 ` [PATCH 2/2] i.MX6ull evk support Sascha Hauer
2017-09-28 9:16 ` Lucas Stach
2017-09-28 9:26 ` Sascha Hauer
2017-09-28 9:33 ` Lucas Stach
2017-09-28 10:13 ` Sascha Hauer [this message]
2017-10-10 14:04 ` Philipp Zabel
2017-09-28 9:09 ` [PATCH 1/2] ARM: i.MX6ull: Add SoC specific lowlevel_init function Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928101345.ohpxhicbbmkvkmce@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox