mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC v4 02/10] RISC-V: add Erizo SoC support
Date: Sat, 30 Sep 2017 15:05:51 +0300	[thread overview]
Message-ID: <20170930150551.4e4a69c8c8280463fbb02562@gmail.com> (raw)
In-Reply-To: <282b43e5-7a6d-8085-a4f3-5f100bfe4953@rempel-privat.de>

On Fri, 29 Sep 2017 14:18:40 +0200
Oleksij Rempel <linux@rempel-privat.de> wrote:

> Probably it is better to send it as patch not as RFC ;)

There are still some issues.
 
> Am 29.09.2017 um 01:12 schrieb Antony Pavlov:

...

> > diff --git a/arch/riscv/boards/erizo-generic/board.c b/arch/riscv/boards/erizo-generic/board.c
> > new file mode 100644
> > index 000000000..ecda85001
> > --- /dev/null
> > +++ b/arch/riscv/boards/erizo-generic/board.c
> > @@ -0,0 +1,28 @@
> > +/*
> > + * Copyright (C) 2016 Antony Pavlov <antonynpavlov@gmail.com>
> > + *
> > + * This file is part of barebox.
> > + * See file CREDITS for list of people who contributed to this project.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2
> > + * as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> > +
> > +#include <common.h>
> > +#include <driver.h>
> > +#include <init.h>
> > +
> > +static int hostname_init(void)
> > +{
> > +	barebox_set_hostname("barebox");
> 
> please, use board name. Maybe: erizo-generic or so.
> For network boot the filenames will be constructed as following:
> username-hostname-filetype


That's a good point!


> 
> > +
> > +	return 0;
> > +}
> > +postcore_initcall(hostname_init);


-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-09-30 11:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 23:12 [RFC v4 00/10] add initial RISC-V architecture support Antony Pavlov
2017-09-28 23:12 ` [RFC v4 01/10] Add " Antony Pavlov
2017-09-29 12:07   ` Oleksij Rempel
2017-09-30 11:57     ` Antony Pavlov
2017-10-02  7:43       ` Oleksij Rempel
2017-10-02 14:08         ` Antony Pavlov
2017-10-02 10:04       ` Daniel Schultz
2017-10-02 22:15         ` Antony Pavlov
2017-10-02 10:08     ` Daniel Schultz
2017-10-02 22:21       ` Antony Pavlov
2017-10-05 10:55         ` Daniel Schultz
2017-10-06 15:39           ` Antony Pavlov
2017-09-28 23:12 ` [RFC v4 02/10] RISC-V: add Erizo SoC support Antony Pavlov
2017-09-29 12:18   ` Oleksij Rempel
2017-09-30 12:05     ` Antony Pavlov [this message]
2017-09-28 23:12 ` [RFC v4 03/10] RISC-V: add low-level debug macros for ns16550 Antony Pavlov
2017-09-28 23:12 ` [RFC v4 04/10] RISC-V: add nmon nano-monitor Antony Pavlov
2017-09-29 12:26   ` Oleksij Rempel
2017-09-30 12:22     ` Antony Pavlov
2017-09-28 23:12 ` [RFC v4 05/10] RISC-V: erizo: add DEBUG_LL support Antony Pavlov
2017-09-28 23:12 ` [RFC v4 06/10] RISC-V: erizo: enable NMON Antony Pavlov
2017-09-28 23:12 ` [RFC v4 07/10] RISC-V: erizo: add nmon image creation Antony Pavlov
2017-09-28 23:12 ` [RFC v4 08/10] RISC-V: add erizo_generic_defconfig Antony Pavlov
2017-09-29 12:29   ` Oleksij Rempel
2017-09-30 12:38     ` Antony Pavlov
2017-09-28 23:12 ` [RFC v4 09/10] scripts: add nmon-loader Antony Pavlov
2017-09-28 23:12 ` [RFC v4 10/10] Documentation: add RISC-V docs Antony Pavlov
2017-09-29 12:35   ` Oleksij Rempel
2017-09-30 12:34     ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930150551.4e4a69c8c8280463fbb02562@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox