* [PATCH] UBI: attach: add missing newline at end of pr_err()
@ 2017-10-15 11:16 Marc Kleine-Budde
2017-10-16 7:02 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Marc Kleine-Budde @ 2017-10-15 11:16 UTC (permalink / raw)
To: barebox
This patch adds the missing newline at the end of the pr_err()
statement.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/mtd/ubi/attach.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
index b49842be3948..ff4b4e7acb76 100644
--- a/drivers/mtd/ubi/attach.c
+++ b/drivers/mtd/ubi/attach.c
@@ -782,7 +782,7 @@ static int check_corruption(struct ubi_device *ubi, struct ubi_vid_hdr *vid_hdr,
pnum);
ubi_err(ubi, "this may be a non-UBI PEB or a severe VID header corruption which requires manual inspection");
ubi_dump_vid_hdr(vid_hdr);
- pr_err("hexdump of PEB %d offset %d, length %d",
+ pr_err("hexdump of PEB %d offset %d, length %d\n",
pnum, ubi->leb_start, ubi->leb_size);
ubi_dbg_print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
ubi->peb_buf, ubi->leb_size, 1);
--
2.14.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] UBI: attach: add missing newline at end of pr_err()
2017-10-15 11:16 [PATCH] UBI: attach: add missing newline at end of pr_err() Marc Kleine-Budde
@ 2017-10-16 7:02 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-10-16 7:02 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: barebox
On Sun, Oct 15, 2017 at 01:16:31PM +0200, Marc Kleine-Budde wrote:
> This patch adds the missing newline at the end of the pr_err()
> statement.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/mtd/ubi/attach.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
> index b49842be3948..ff4b4e7acb76 100644
> --- a/drivers/mtd/ubi/attach.c
> +++ b/drivers/mtd/ubi/attach.c
> @@ -782,7 +782,7 @@ static int check_corruption(struct ubi_device *ubi, struct ubi_vid_hdr *vid_hdr,
> pnum);
> ubi_err(ubi, "this may be a non-UBI PEB or a severe VID header corruption which requires manual inspection");
> ubi_dump_vid_hdr(vid_hdr);
> - pr_err("hexdump of PEB %d offset %d, length %d",
> + pr_err("hexdump of PEB %d offset %d, length %d\n",
> pnum, ubi->leb_start, ubi->leb_size);
> ubi_dbg_print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 1,
> ubi->peb_buf, ubi->leb_size, 1);
> --
> 2.14.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-15 11:16 [PATCH] UBI: attach: add missing newline at end of pr_err() Marc Kleine-Budde
2017-10-16 7:02 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox