mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Enrico Jorns <ejo@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] efi: add missing Kconfig selects
Date: Mon, 16 Oct 2017 09:30:22 +0200	[thread overview]
Message-ID: <20171016073021.4fh6buyg3apngzub@pengutronix.de> (raw)
In-Reply-To: <20171011132042.3564-1-ejo@pengutronix.de>

On Wed, Oct 11, 2017 at 03:20:42PM +0200, Enrico Jorns wrote:
> Building EFI code without block device and partition support enabled
> will fail with:
> 
> | drivers/built-in.o: In function `efi_bio_probe':
> | (.text+0x125d): undefined reference to `blockdevice_register'
> | drivers/built-in.o: In function `efi_bio_probe':
> | (.text+0x126c): undefined reference to `parse_partition_table'
> | Makefile:766: recipe for target 'barebox' failed
> 
> Thus always select BLOCK and PARTITION_DISK when enabling EFI_BOOTUP.
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  drivers/efi/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/efi/Kconfig b/drivers/efi/Kconfig
> index 2cd9dd504f..cca1a2e1d6 100644
> --- a/drivers/efi/Kconfig
> +++ b/drivers/efi/Kconfig
> @@ -1,2 +1,4 @@
>  config EFI_BOOTUP
>  	bool
> +	select BLOCK
> +	select PARTITION_DISK
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2017-10-16  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 13:20 Enrico Jorns
2017-10-16  7:30 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016073021.4fh6buyg3apngzub@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=ejo@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox