mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] efi: add missing Kconfig selects
@ 2017-10-11 13:20 Enrico Jorns
  2017-10-16  7:30 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Enrico Jorns @ 2017-10-11 13:20 UTC (permalink / raw)
  To: barebox; +Cc: Enrico Jorns

Building EFI code without block device and partition support enabled
will fail with:

| drivers/built-in.o: In function `efi_bio_probe':
| (.text+0x125d): undefined reference to `blockdevice_register'
| drivers/built-in.o: In function `efi_bio_probe':
| (.text+0x126c): undefined reference to `parse_partition_table'
| Makefile:766: recipe for target 'barebox' failed

Thus always select BLOCK and PARTITION_DISK when enabling EFI_BOOTUP.

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
---
 drivers/efi/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/efi/Kconfig b/drivers/efi/Kconfig
index 2cd9dd504f..cca1a2e1d6 100644
--- a/drivers/efi/Kconfig
+++ b/drivers/efi/Kconfig
@@ -1,2 +1,4 @@
 config EFI_BOOTUP
 	bool
+	select BLOCK
+	select PARTITION_DISK
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] efi: add missing Kconfig selects
  2017-10-11 13:20 [PATCH] efi: add missing Kconfig selects Enrico Jorns
@ 2017-10-16  7:30 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-10-16  7:30 UTC (permalink / raw)
  To: Enrico Jorns; +Cc: barebox

On Wed, Oct 11, 2017 at 03:20:42PM +0200, Enrico Jorns wrote:
> Building EFI code without block device and partition support enabled
> will fail with:
> 
> | drivers/built-in.o: In function `efi_bio_probe':
> | (.text+0x125d): undefined reference to `blockdevice_register'
> | drivers/built-in.o: In function `efi_bio_probe':
> | (.text+0x126c): undefined reference to `parse_partition_table'
> | Makefile:766: recipe for target 'barebox' failed
> 
> Thus always select BLOCK and PARTITION_DISK when enabling EFI_BOOTUP.
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  drivers/efi/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/efi/Kconfig b/drivers/efi/Kconfig
> index 2cd9dd504f..cca1a2e1d6 100644
> --- a/drivers/efi/Kconfig
> +++ b/drivers/efi/Kconfig
> @@ -1,2 +1,4 @@
>  config EFI_BOOTUP
>  	bool
> +	select BLOCK
> +	select PARTITION_DISK
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-16  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 13:20 [PATCH] efi: add missing Kconfig selects Enrico Jorns
2017-10-16  7:30 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox