From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] eeprom: at24: fix 'assignment from incompatible pointer type' warning
Date: Mon, 16 Oct 2017 10:23:18 +0200 [thread overview]
Message-ID: <20171016082318.tvxuqq2h2aqrh4w4@pengutronix.de> (raw)
In-Reply-To: <20171009221212.24377-1-antonynpavlov@gmail.com>
On Tue, Oct 10, 2017 at 01:12:12AM +0300, Antony Pavlov wrote:
> The patch fixes this compiler's warning:
>
> CC drivers/eeprom/at24.o
> drivers/eeprom/at24.c: In function ‘at24_probe’:
> drivers/eeprom/at24.c:453:21: warning: assignment from incompatible
> pointer type [-Wincompatible-pointer-types]
> at24->fops.protect = at24_cdev_protect,
> ^
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/eeprom/at24.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/eeprom/at24.c b/drivers/eeprom/at24.c
> index 050a35aed8..11f23319b6 100644
> --- a/drivers/eeprom/at24.c
> +++ b/drivers/eeprom/at24.c
> @@ -352,7 +352,7 @@ static ssize_t at24_cdev_write(struct cdev *cdev, const void *buf, size_t count,
> return at24_write(at24, buf, off, count);
> }
>
> -static ssize_t at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
> +static int at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
> int prot)
> {
> struct at24_data *at24 = cdev->priv;
> --
> 2.14.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-10-16 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 22:12 Antony Pavlov
2017-10-16 8:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016082318.tvxuqq2h2aqrh4w4@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox