[PATCH] eeprom: at24: fix 'assignment from incompatible pointer type' warning

[PATCH] eeprom: at24: fix 'assignment from incompatible pointer type' warning

[Antony Pavlov]

The patch fixes this compiler's warning:

      CC      drivers/eeprom/at24.o
    drivers/eeprom/at24.c: In function ‘at24_probe’:
    drivers/eeprom/at24.c:453:21: warning: assignment from incompatible
    pointer type [-Wincompatible-pointer-types]
      at24->fops.protect = at24_cdev_protect,
                         ^

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/eeprom/at24.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/eeprom/at24.c b/drivers/eeprom/at24.c
index 050a35aed8..11f23319b6 100644
--- a/drivers/eeprom/at24.c
+++ b/drivers/eeprom/at24.c
@@ -352,7 +352,7 @@ static ssize_t at24_cdev_write(struct cdev *cdev, const void *buf, size_t count,
 	return at24_write(at24, buf, off, count);
 }
 
-static ssize_t at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
+static int at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
 		int prot)
 {
 	struct at24_data *at24 = cdev->priv;
-- 
2.14.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] eeprom: at24: fix 'assignment from incompatible pointer type' warning

[Sascha Hauer]

On Tue, Oct 10, 2017 at 01:12:12AM +0300, Antony Pavlov wrote:
> The patch fixes this compiler's warning:
> 
>       CC      drivers/eeprom/at24.o
>     drivers/eeprom/at24.c: In function ‘at24_probe’:
>     drivers/eeprom/at24.c:453:21: warning: assignment from incompatible
>     pointer type [-Wincompatible-pointer-types]
>       at24->fops.protect = at24_cdev_protect,
>                          ^
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/eeprom/at24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/eeprom/at24.c b/drivers/eeprom/at24.c
> index 050a35aed8..11f23319b6 100644
> --- a/drivers/eeprom/at24.c
> +++ b/drivers/eeprom/at24.c
> @@ -352,7 +352,7 @@ static ssize_t at24_cdev_write(struct cdev *cdev, const void *buf, size_t count,
>  	return at24_write(at24, buf, off, count);
>  }
>  
> -static ssize_t at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
> +static int at24_cdev_protect(struct cdev *cdev, size_t count, loff_t offset,
>  		int prot)
>  {
>  	struct at24_data *at24 = cdev->priv;
> -- 
> 2.14.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox