[PATCH] OMAP_GPMC: this driver depends on MTD

[PATCH] OMAP_GPMC: this driver depends on MTD

[Juergen Borleis]

Otherwise it fails with:

drivers/bus/omap-gpmc.c:498: undefined reference to `of_get_nand_bus_width'

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
 drivers/bus/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 202df5976..61f9064f5 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -4,6 +4,7 @@ config BUS_OMAP_GPMC
 	depends on ARCH_OMAP
 	depends on OFDEVICE
 	depends on OMAP_GPMC
+	depends on MTD
 	bool "TI OMAP/AM33xx GPMC support"
 
 config IMX_WEIM
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] OMAP_GPMC: this driver depends on MTD

[Sascha Hauer]

Hi Jürgen,

On Mon, Oct 16, 2017 at 10:01:46AM +0200, Juergen Borleis wrote:
> Otherwise it fails with:
> 
> drivers/bus/omap-gpmc.c:498: undefined reference to `of_get_nand_bus_width'
> 
> Signed-off-by: Juergen Borleis <jbe@pengutronix.de>

I would prefer a

	if (IS_ENABLED(CONFIG_MTD) && !strncmp(child->name, "nand", 4))
		ret = gpmc_probe_nand_child(dev, child);

That would allow to use the GPMC without MTD support which is a valid
usecase if for example only a network device is connected.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox