From: Sascha Hauer <s.hauer@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] regmap: port regmap_update_bits from linux
Date: Mon, 16 Oct 2017 10:35:37 +0200 [thread overview]
Message-ID: <20171016083537.bykiglghw73ds3fx@pengutronix.de> (raw)
In-Reply-To: <20171006095302.9602-1-s.trumtrar@pengutronix.de>
On Fri, Oct 06, 2017 at 11:53:02AM +0200, Steffen Trumtrar wrote:
> Port the regmap_update_bits function from linux v4.14-rc1 to barebox.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> drivers/base/regmap/regmap.c | 29 +++++++++++++++++++++++++++++
> include/regmap.h | 3 ++-
> 2 files changed, 31 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index 52b7d88c74ed..67d95fe30a0b 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -137,6 +137,35 @@ int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val)
> }
>
> /**
> + * regmap_update_bits() - Perform a read/modify/write cycle on a register
> + *
> + * @map: Register map to update
> + * @reg: Register to update
> + * @mask: Bitmask to change
> + * @val: New value for bitmask
> + *
> + * Returns zero for success, a negative number on error.
> + */
> +int regmap_update_bits(struct regmap *map, unsigned int reg,
> + unsigned int mask, unsigned int val)
> +{
> + int ret;
> + unsigned int tmp, orig;
> +
> + ret = regmap_read(map, reg, &orig);
> + if (ret != 0)
> + return ret;
> +
> + tmp = orig & ~mask;
> + tmp |= val & mask;
> +
> + if (tmp != orig)
> + ret = regmap_write(map, reg, tmp);
> +
> + return ret;
> +}
> +
> +/**
> * regmap_write_bits - write bits of a register in a map
> *
> * @map: The map
> diff --git a/include/regmap.h b/include/regmap.h
> index 9675a17b9641..09b7b57d52f3 100644
> --- a/include/regmap.h
> +++ b/include/regmap.h
> @@ -62,6 +62,7 @@ int regmap_get_reg_stride(struct regmap *map);
>
> int regmap_write_bits(struct regmap *map, unsigned int reg,
> unsigned int mask, unsigned int val);
> -
> +int regmap_update_bits(struct regmap *map, unsigned int reg,
> + unsigned int mask, unsigned int val);
>
> #endif /* __REGMAP_H */
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-10-16 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 9:53 Steffen Trumtrar
2017-10-16 8:35 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016083537.bykiglghw73ds3fx@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox