* [PATCH] mtd: m25p80: make it possible to use 4K erase block @ 2017-04-26 14:17 Antony Pavlov 2017-04-28 8:18 ` Sascha Hauer 0 siblings, 1 reply; 6+ messages in thread From: Antony Pavlov @ 2017-04-26 14:17 UTC (permalink / raw) To: barebox We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code for 4K erase block support. Alas this 4K erase block support code can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support is missed in Kconfig. This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option declaration from linux v4.11-rc8. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> --- drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index a84591fdd1..8ede3c90be 100644 --- a/drivers/mtd/spi-nor/Kconfig +++ b/drivers/mtd/spi-nor/Kconfig @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR if MTD_SPI_NOR +config MTD_SPI_NOR_USE_4K_SECTORS + bool "Use small 4096 B erase sectors" + default y + help + Many flash memories support erasing small (4096 B) sectors. Depending + on the usage this feature may provide performance gain in comparison + to erasing whole blocks (32/64 KiB). + Changing a small part of the flash's contents is usually faster with + small sectors. On the other hand erasing should be faster when using + 64 KiB block instead of 16 × 4 KiB sectors. + + Please note that some tools/drivers/filesystems may not work with + 4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum). + config SPI_CADENCE_QUADSPI tristate "Cadence Quad SPI controller" help -- 2.11.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block 2017-04-26 14:17 [PATCH] mtd: m25p80: make it possible to use 4K erase block Antony Pavlov @ 2017-04-28 8:18 ` Sascha Hauer 2017-04-28 10:57 ` Antony Pavlov 0 siblings, 1 reply; 6+ messages in thread From: Sascha Hauer @ 2017-04-28 8:18 UTC (permalink / raw) To: Antony Pavlov; +Cc: barebox On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote: > We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code > for 4K erase block support. Alas this 4K erase block support code > can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support > is missed in Kconfig. > > This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option > declaration from linux v4.11-rc8. > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > --- > drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index a84591fdd1..8ede3c90be 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR > > if MTD_SPI_NOR > > +config MTD_SPI_NOR_USE_4K_SECTORS > + bool "Use small 4096 B erase sectors" > + default y This changes the default which breaks existing UBI users. Can you drop this? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block 2017-04-28 8:18 ` Sascha Hauer @ 2017-04-28 10:57 ` Antony Pavlov 2017-10-12 17:01 ` Antony Pavlov 0 siblings, 1 reply; 6+ messages in thread From: Antony Pavlov @ 2017-04-28 10:57 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On Fri, 28 Apr 2017 10:18:48 +0200 Sascha Hauer <s.hauer@pengutronix.de> wrote: > On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote: > > We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code > > for 4K erase block support. Alas this 4K erase block support code > > can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support > > is missed in Kconfig. > > > > This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option > > declaration from linux v4.11-rc8. > > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > > --- > > drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > index a84591fdd1..8ede3c90be 100644 > > --- a/drivers/mtd/spi-nor/Kconfig > > +++ b/drivers/mtd/spi-nor/Kconfig > > @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR > > > > if MTD_SPI_NOR > > > > +config MTD_SPI_NOR_USE_4K_SECTORS > > + bool "Use small 4096 B erase sectors" > > + default y > > This changes the default which breaks existing UBI users. Can you drop > this? Yes, we can drop this 'default y'. -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block 2017-04-28 10:57 ` Antony Pavlov @ 2017-10-12 17:01 ` Antony Pavlov 2017-10-16 7:26 ` Sascha Hauer 0 siblings, 1 reply; 6+ messages in thread From: Antony Pavlov @ 2017-10-12 17:01 UTC (permalink / raw) To: Sascha Hauer, barebox On Fri, 28 Apr 2017 13:57:27 +0300 Antony Pavlov <antonynpavlov@gmail.com> wrote: > On Fri, 28 Apr 2017 10:18:48 +0200 > Sascha Hauer <s.hauer@pengutronix.de> wrote: > > > On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote: > > > We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code > > > for 4K erase block support. Alas this 4K erase block support code > > > can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support > > > is missed in Kconfig. > > > > > > This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option > > > declaration from linux v4.11-rc8. > > > > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > > > --- > > > drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > > index a84591fdd1..8ede3c90be 100644 > > > --- a/drivers/mtd/spi-nor/Kconfig > > > +++ b/drivers/mtd/spi-nor/Kconfig > > > @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR > > > > > > if MTD_SPI_NOR > > > > > > +config MTD_SPI_NOR_USE_4K_SECTORS > > > + bool "Use small 4096 B erase sectors" > > > + default y > > > > This changes the default which breaks existing UBI users. Can you drop > > this? > > Yes, we can drop this 'default y'. ping -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block 2017-10-12 17:01 ` Antony Pavlov @ 2017-10-16 7:26 ` Sascha Hauer 2017-10-16 14:04 ` Antony Pavlov 0 siblings, 1 reply; 6+ messages in thread From: Sascha Hauer @ 2017-10-16 7:26 UTC (permalink / raw) To: Antony Pavlov; +Cc: barebox On Thu, Oct 12, 2017 at 08:01:33PM +0300, Antony Pavlov wrote: > On Fri, 28 Apr 2017 13:57:27 +0300 > Antony Pavlov <antonynpavlov@gmail.com> wrote: > > > On Fri, 28 Apr 2017 10:18:48 +0200 > > Sascha Hauer <s.hauer@pengutronix.de> wrote: > > > > > On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote: > > > > We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code > > > > for 4K erase block support. Alas this 4K erase block support code > > > > can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support > > > > is missed in Kconfig. > > > > > > > > This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option > > > > declaration from linux v4.11-rc8. > > > > > > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > > > > --- > > > > drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ > > > > 1 file changed, 14 insertions(+) > > > > > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > > > index a84591fdd1..8ede3c90be 100644 > > > > --- a/drivers/mtd/spi-nor/Kconfig > > > > +++ b/drivers/mtd/spi-nor/Kconfig > > > > @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR > > > > > > > > if MTD_SPI_NOR > > > > > > > > +config MTD_SPI_NOR_USE_4K_SECTORS > > > > + bool "Use small 4096 B erase sectors" > > > > + default y > > > > > > This changes the default which breaks existing UBI users. Can you drop > > > this? > > > > Yes, we can drop this 'default y'. > > ping ping? I expected to see a new version of the patch. Well, I fixed this up and applied for now, to get this topic done. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: make it possible to use 4K erase block 2017-10-16 7:26 ` Sascha Hauer @ 2017-10-16 14:04 ` Antony Pavlov 0 siblings, 0 replies; 6+ messages in thread From: Antony Pavlov @ 2017-10-16 14:04 UTC (permalink / raw) To: Sascha Hauer; +Cc: barebox On Mon, 16 Oct 2017 09:26:00 +0200 Sascha Hauer <s.hauer@pengutronix.de> wrote: > On Thu, Oct 12, 2017 at 08:01:33PM +0300, Antony Pavlov wrote: > > On Fri, 28 Apr 2017 13:57:27 +0300 > > Antony Pavlov <antonynpavlov@gmail.com> wrote: > > > > > On Fri, 28 Apr 2017 10:18:48 +0200 > > > Sascha Hauer <s.hauer@pengutronix.de> wrote: > > > > > > > On Wed, Apr 26, 2017 at 05:17:34PM +0300, Antony Pavlov wrote: > > > > > We already have the MTD_SPI_NOR_USE_4K_SECTORS option handling in C code > > > > > for 4K erase block support. Alas this 4K erase block support code > > > > > can't be used because the MTD_SPI_NOR_USE_4K_SECTORS option support > > > > > is missed in Kconfig. > > > > > > > > > > This patch imports necessary Kconfig MTD_SPI_NOR_USE_4K_SECTORS option > > > > > declaration from linux v4.11-rc8. > > > > > > > > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > > > > > --- > > > > > drivers/mtd/spi-nor/Kconfig | 14 ++++++++++++++ > > > > > 1 file changed, 14 insertions(+) > > > > > > > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > > > > index a84591fdd1..8ede3c90be 100644 > > > > > --- a/drivers/mtd/spi-nor/Kconfig > > > > > +++ b/drivers/mtd/spi-nor/Kconfig > > > > > @@ -7,6 +7,20 @@ menuconfig MTD_SPI_NOR > > > > > > > > > > if MTD_SPI_NOR > > > > > > > > > > +config MTD_SPI_NOR_USE_4K_SECTORS > > > > > + bool "Use small 4096 B erase sectors" > > > > > + default y > > > > > > > > This changes the default which breaks existing UBI users. Can you drop > > > > this? > > > > > > Yes, we can drop this 'default y'. > > > > ping > > ping? I expected to see a new version of the patch. Well, I fixed this > up and applied for now, to get this topic done. Sorry! I have been confused. The patch has been too long in my local branch. -- Best regards, Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-16 13:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-26 14:17 [PATCH] mtd: m25p80: make it possible to use 4K erase block Antony Pavlov 2017-04-28 8:18 ` Sascha Hauer 2017-04-28 10:57 ` Antony Pavlov 2017-10-12 17:01 ` Antony Pavlov 2017-10-16 7:26 ` Sascha Hauer 2017-10-16 14:04 ` Antony Pavlov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox