From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e45uN-0004Di-C8 for barebox@lists.infradead.org; Mon, 16 Oct 2017 13:58:22 +0000 Received: by mail-lf0-x244.google.com with SMTP id p184so17107633lfe.12 for ; Mon, 16 Oct 2017 06:57:59 -0700 (PDT) Date: Mon, 16 Oct 2017 17:10:11 +0300 From: Antony Pavlov Message-Id: <20171016171011.934b4475b230c7ccaca5f88c@gmail.com> In-Reply-To: <20171016082158.mclujzfzsdvhjcvq@pengutronix.de> References: <20171010122631.9421-1-antonynpavlov@gmail.com> <20171010122631.9421-4-antonynpavlov@gmail.com> <20171016082158.mclujzfzsdvhjcvq@pengutronix.de> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/5] sandbox: parse libftdi options To: Sascha Hauer Cc: barebox@lists.infradead.org On Mon, 16 Oct 2017 10:21:58 +0200 Sascha Hauer wrote: > On Tue, Oct 10, 2017 at 03:26:29PM +0300, Antony Pavlov wrote: > > Signed-off-by: Antony Pavlov > > --- > > arch/sandbox/Makefile | 2 +- > > arch/sandbox/os/common.c | 12 ++++++-- > > arch/sandbox/os/ftdi.c | 79 ++++++++++++++++++++++++++++++++++++++++= +++++++- > > 3 files changed, 89 insertions(+), 4 deletions(-) > > = > > diff --git a/arch/sandbox/os/ftdi.c b/arch/sandbox/os/ftdi.c > > index 34e9165787..e3e46ed12d 100644 > > --- a/arch/sandbox/os/ftdi.c > > +++ b/arch/sandbox/os/ftdi.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > = > > #define FTDI_VID 0x0403 /* Vendor Id */ > > @@ -38,6 +39,8 @@ struct ft2232_bitbang { > > = > > static struct ft2232_bitbang ftbb; > > = > > +extern const char *libftdi_options; > > + > > static inline int ftdi_flush(struct ftdi_context *ftdi) > > { > > uint8_t buf[1]; > > @@ -116,6 +119,67 @@ void barebox_libftdi1_gpio_set_value(struct ft2232= _bitbang *ftbb, > > ftbb->odata &=3D ~BIT(off); > > } > > = > > +/* This is a somewhat hacked function similar in some ways to strtok(). > > + * It will look for needle with a subsequent '=3D' in haystack, return= a copy of > > + * needle and remove everything from the first occurrence of needle to= the next > > + * delimiter from haystack. > > + */ > > +static char *extract_param(const char *const *haystack, const char *ne= edle, > > + const char *delim) > > +{ > = > Parsing comma separated option lists is something we do more than once. > Right now we already have parseopt_b and parseopt_hu. Would be nice to > have this function alongside with the existing functions. Also > parseopt_* look simpler to follow, it may be worth adopting the code for > this function. At the moment the parseopt_* functions are in the fs/parseopt.c file. Adding the parseopt_ul() for parsing u32 option value in arch/sandbox/os/ft= di.c will lead to moving fs/parseopt.c file to common code, e.g. to lib/. Is it ok to add 'obj-y +=3D parseopt.o' to the lib/Makefile file? May be you prefere to introduce special Kconfig option for parseopt.o condi= tional compilation? -- = Best regards, =A0 Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox