* [PATCH] graphic_utils: Fix freeing uninitialzed pointer in fb_open()
@ 2017-10-19 10:13 Sascha Hauer
0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2017-10-19 10:13 UTC (permalink / raw)
To: Barebox List
In fb_open() when fb_create_screen() fails then sc contains an
error pointer which is then freed in the failure path. Fix this.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
lib/gui/graphic_utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/gui/graphic_utils.c b/lib/gui/graphic_utils.c
index 7d238e9ff9..0bed932213 100644
--- a/lib/gui/graphic_utils.c
+++ b/lib/gui/graphic_utils.c
@@ -285,15 +285,13 @@ struct screen *fb_open(const char * fbdev)
sc = fb_create_screen(info);
if (IS_ERR(sc)) {
ret = PTR_ERR(sc);
- goto failed_create;
+ goto failed_screeninfo;
}
sc->fd = fd;
return sc;
-failed_create:
- free(sc);
failed_screeninfo:
close(fd);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-19 10:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 10:13 [PATCH] graphic_utils: Fix freeing uninitialzed pointer in fb_open() Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox