From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: i.MX: bbu-internal: update board files to make use of new bbu handler
Date: Mon, 23 Oct 2017 10:05:24 +0200 [thread overview]
Message-ID: <20171023080524.yp3hskyrcia7ao2m@pengutronix.de> (raw)
In-Reply-To: <20171023075520.3wmzpqemg5eqffzu@pengutronix.de>
On Mon, Oct 23, 2017 at 09:55:20AM +0200, Uwe Kleine-König wrote:
> Hello Sascha,
>
> On Mon, Oct 23, 2017 at 09:23:56AM +0200, Sascha Hauer wrote:
> > On Wed, Oct 18, 2017 at 03:41:17PM +0200, Uwe Kleine-König wrote:
> > > diff --git a/arch/arm/boards/dfi-fs700-m60/board.c b/arch/arm/boards/dfi-fs700-m60/board.c
> > > index bef4612d9e66..c2c73db8e547 100644
> > > --- a/arch/arm/boards/dfi-fs700-m60/board.c
> > > +++ b/arch/arm/boards/dfi-fs700-m60/board.c
> > > @@ -110,8 +110,7 @@ static int dfi_fs700_m60_init(void)
> > > else
> > > flag_mmc |= BBU_HANDLER_FLAG_DEFAULT;
> > >
> > > - imx6_bbu_internal_mmc_register_handler("mmc", "/dev/mmc3.boot0",
> > > - flag_mmc);
> > > + imx6_bbu_internal_mmcboot_register_handler("mmc", "mmc3", flag_mmc);
> >
> > This board at least uses the boot1 partition for the environment, so we
> > can't use your new handler without moving the environment first.
>
> Good catch, I will drop this board's modifications then.
I haven't checked the other boards, they may or may not do the same.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-10-23 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 13:41 [PATCH 1/3] ARM: i.MX: bbu-internal: make filename for device to write to adaptable Uwe Kleine-König
2017-10-18 13:41 ` [PATCH 2/3] ARM: i.MX: bbu-internal: new handler to make use of mmc boot partitions Uwe Kleine-König
2017-10-23 7:20 ` Sascha Hauer
2017-10-23 7:54 ` Uwe Kleine-König
2017-10-18 13:41 ` [PATCH 3/3] ARM: i.MX: bbu-internal: update board files to make use of new bbu handler Uwe Kleine-König
2017-10-23 7:23 ` Sascha Hauer
2017-10-23 7:55 ` Uwe Kleine-König
2017-10-23 8:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023080524.yp3hskyrcia7ao2m@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox