From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFcvR-0001av-Ti for barebox@lists.infradead.org; Fri, 17 Nov 2017 09:27:07 +0000 Date: Fri, 17 Nov 2017 10:26:41 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20171117092641.cbrszaoh4cfz5eku@pengutronix.de> References: <20171108150517.130503-1-g.schenk@eckelmann.de> <20171110070008.p6gsmknadybwq6ug@pengutronix.de> <1510816812.1406.2.camel@eckelmann.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1510816812.1406.2.camel@eckelmann.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] Configure network device for nfsboot via nv var To: "Schenk, Gavin" Cc: "barebox@lists.infradead.org" Hello, On Thu, Nov 16, 2017 at 07:20:14AM +0000, Schenk, Gavin wrote: > > On Wed, Nov 08, 2017 at 04:05:17PM +0100, Gavin Schenk wrote: > > > When you have a static network environment but more than one > > > network > > > device on your machine it is necessary to provide the > > > parameter to the ip parameter at kernel cmd line. > > > = > > > The device name assigned by Linux cannot in general be predicted as > > > it > > > depends on driver bind order. > > > = > > > This patch introduces a new global variable > > > "global.linux.nfsroot.device" which when set is feed to the ip=3D > > > kernel > > > parameter as device name. > > = > > Maybe we should rather add a linuxname property to the ethernet > > device > > instead. That way we could specify multiple names in case we have > > multiple ethernet devices in barebox aswell. > > = > = > maybe I am missing something important, but is this useful for anything > besides nfsboot? > = > If linuxname is a property of the device, how do we decide between > eth0.linuxname and eth1.linuxname when doing a "boot /mnt/nfs"?=A0 > In this case we need additionally a global variable like nfsboot- > device=3Deth0 to switch between nfsboot devices and to make the decision > when filling the ip parameter? IMHO this is unnecessary complicated and the suggested patch is fine. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox