mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 0/6] net/e1000: more cleanups and ways to access i210 storage
Date: Fri, 24 Nov 2017 10:06:43 +0100	[thread overview]
Message-ID: <20171124090643.dp35rgx5y5duz5i6@pengutronix.de> (raw)
In-Reply-To: <20171122102231.16872-1-u.kleine-koenig@pengutronix.de>

On Wed, Nov 22, 2017 at 11:22:25AM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> these are a few patches that cumulated here related to the i210 network
> controller.
> 
> These are nearly good enough to populate the attached flash with a valid
> firmware (which you still need to have yourself) on all machines I have
> access to.
> 
> There is still one (to me) known problem: When the flash doesn't contain
> a valid image, accessing the eeprom (which is a simulated device on i210
> that is backed up by shadow RAM and the two first pages of flash) gives
> the contents of iNVM instead of the expected default eeprom. That
> results in a few wrong turns in the code but they are not grave enough
> to stop being able to write a valid firmware image.
> 
> A bit that is still missing is that a customer machine uses an flash
> that is write protected at power on. An i210 with an programmed flash is
> clever enough to remove the write protection before writing to it, but
> that doesn't help when the flash is not programmed (tin opener inside).
> I have a prototype that can remove the write protection with a
> cryptic command but that's not ready for prime time yet.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (6):
>   net/e1000: fix coding style at a few locations
>   net/e1000: don't use the eeprom word size as timeout to get a
>     semaphore
>   net/e1000: reorder functions
>   net/e1000: provide access to iNVM even if a flash is present
>   net/e1000: fix size of invm device
>   net/e1000: provide device for accessing emulated eeprom
> 
>  drivers/net/e1000/e1000.h  |   8 +-
>  drivers/net/e1000/eeprom.c | 324 ++++++++++++++++++++++++++-------------------
>  drivers/net/e1000/main.c   |   6 +-
>  3 files changed, 196 insertions(+), 142 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2017-11-24  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 10:22 Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 1/6] net/e1000: fix coding style at a few locations Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 2/6] net/e1000: don't use the eeprom word size as timeout to get a semaphore Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 3/6] net/e1000: reorder functions Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 4/6] net/e1000: provide access to iNVM even if a flash is present Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 5/6] net/e1000: fix size of invm device Uwe Kleine-König
2017-11-22 10:22 ` [PATCH 6/6] net/e1000: provide device for accessing emulated eeprom Uwe Kleine-König
2017-11-23 11:12 ` [PATCH 7/6] net/e1000: don't fail to bind on uninitialized flash Uwe Kleine-König
2017-11-23 11:12   ` [PATCH 8/6] net/e1000: log flash/invm status at probe time Uwe Kleine-König
2017-11-23 11:12   ` [PATCH 9/6] net/e1000: don't access the (simulated) eeprom when it is invalid Uwe Kleine-König
2017-11-23 11:12   ` [PATCH 10/6] net/e1000: indicate in error messages where the failure occured Uwe Kleine-König
2017-11-23 11:12   ` [PATCH 11/6] net/e1000: expand timeout for flash erasure Uwe Kleine-König
2017-11-24  9:06 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171124090643.dp35rgx5y5duz5i6@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox