From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <r.hieber@pengutronix.de>
Cc: barebox@lists.infradead.org, Alexander Dahl <post@lespocky.de>,
Roland Hieber <rohieb@rohieb.name>
Subject: Re: [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card
Date: Thu, 7 Dec 2017 16:19:42 +0100 [thread overview]
Message-ID: <20171207151942.wmz7nicr2gozjjib@pengutronix.de> (raw)
In-Reply-To: <20171206151233.29342-1-r.hieber@pengutronix.de>
On Wed, Dec 06, 2017 at 04:12:33PM +0100, Roland Hieber wrote:
> From: Roland Hieber <rohieb@rohieb.name>
>
> Kernel commit a19adf8d86e822eba502486524127595372c85f6 [0] changed the
> RPi1 device tree from &sdhci to &sdhost, which was imported in barebox
> commit d14b844b08635c717fb52a294ed8d6872e260315. It seems that barebox
> does not have a driver for brcm,bcm2835-sdhost (yet), which resulted in
> barebox unable to boot from SD card. However, the driver for
> brcm,bcm2835-sdhci worked fine in the past.
>
> Although the upstream change was made for good reasons, the simplest
> change for barebox for now is to revert to using &sdhci and disable
> &sdhost.
>
> Thanks to Alexander Dahl for raising this issue on the DistroKit
> mailing list!
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a19adf8d86e822eba502486524127595372c85f6
>
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
> arch/arm/dts/bcm2835-rpi.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/dts/bcm2835-rpi.dts b/arch/arm/dts/bcm2835-rpi.dts
> index 0095f58a3c..ab2d6dff64 100644
> --- a/arch/arm/dts/bcm2835-rpi.dts
> +++ b/arch/arm/dts/bcm2835-rpi.dts
> @@ -9,3 +9,10 @@
> reg = <0x0 0x0>;
> };
> };
> +&sdhci {
> + status = "okay";
> +};
> +
> +&sdhost {
> + status = "disabled";
> +};
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-12-07 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 15:12 Roland Hieber
2017-12-06 15:17 ` Lucas Stach
2017-12-06 16:06 ` Alexander Dahl
2017-12-07 15:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207151942.wmz7nicr2gozjjib@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=post@lespocky.de \
--cc=r.hieber@pengutronix.de \
--cc=rohieb@rohieb.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox