* Re: [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card
2017-12-06 15:12 [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card Roland Hieber
@ 2017-12-06 15:17 ` Lucas Stach
2017-12-06 16:06 ` Alexander Dahl
2017-12-07 15:19 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2017-12-06 15:17 UTC (permalink / raw)
To: Roland Hieber, barebox; +Cc: Alexander Dahl, Roland Hieber
Am Mittwoch, den 06.12.2017, 16:12 +0100 schrieb Roland Hieber:
> From: Roland Hieber <rohieb@rohieb.name>
>
> Kernel commit a19adf8d86e822eba502486524127595372c85f6 [0] changed
> the
> RPi1 device tree from &sdhci to &sdhost, which was imported in
> barebox
> commit d14b844b08635c717fb52a294ed8d6872e260315. It seems that
> barebox
> does not have a driver for brcm,bcm2835-sdhost (yet), which resulted
> in
> barebox unable to boot from SD card. However, the driver for
> brcm,bcm2835-sdhci worked fine in the past.
>
> Although the upstream change was made for good reasons, the simplest
> change for barebox for now is to revert to using &sdhci and disable
> &sdhost.
>
> Thanks to Alexander Dahl for raising this issue on the DistroKit
> mailing list!
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g
> it/commit/?id=a19adf8d86e822eba502486524127595372c85f6
>
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
> arch/arm/dts/bcm2835-rpi.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/bcm2835-rpi.dts b/arch/arm/dts/bcm2835-
> rpi.dts
> index 0095f58a3c..ab2d6dff64 100644
> --- a/arch/arm/dts/bcm2835-rpi.dts
> +++ b/arch/arm/dts/bcm2835-rpi.dts
> @@ -9,3 +9,10 @@
> reg = <0x0 0x0>;
> };
> };
Missing newline here. Other than that:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> +&sdhci {
> + status = "okay";
> +};
> +
> +&sdhost {
> + status = "disabled";
> +};
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card
2017-12-06 15:12 [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card Roland Hieber
2017-12-06 15:17 ` Lucas Stach
@ 2017-12-06 16:06 ` Alexander Dahl
2017-12-07 15:19 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Dahl @ 2017-12-06 16:06 UTC (permalink / raw)
To: Roland Hieber; +Cc: barebox, Roland Hieber
[-- Attachment #1.1: Type: text/plain, Size: 2127 bytes --]
Hei hei,
as already stated on the DistroKit list: I'm not sure if this is the
right approach for barebox, however I successfully tested it on top of
master.
Greets
Alex
Tested-by: Alexander Dahl <post@lespocky.de>
On Wed, Dec 06, 2017 at 04:12:33PM +0100, Roland Hieber wrote:
> From: Roland Hieber <rohieb@rohieb.name>
>
> Kernel commit a19adf8d86e822eba502486524127595372c85f6 [0] changed the
> RPi1 device tree from &sdhci to &sdhost, which was imported in barebox
> commit d14b844b08635c717fb52a294ed8d6872e260315. It seems that barebox
> does not have a driver for brcm,bcm2835-sdhost (yet), which resulted in
> barebox unable to boot from SD card. However, the driver for
> brcm,bcm2835-sdhci worked fine in the past.
>
> Although the upstream change was made for good reasons, the simplest
> change for barebox for now is to revert to using &sdhci and disable
> &sdhost.
>
> Thanks to Alexander Dahl for raising this issue on the DistroKit
> mailing list!
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a19adf8d86e822eba502486524127595372c85f6
>
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
> arch/arm/dts/bcm2835-rpi.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/bcm2835-rpi.dts b/arch/arm/dts/bcm2835-rpi.dts
> index 0095f58a3c..ab2d6dff64 100644
> --- a/arch/arm/dts/bcm2835-rpi.dts
> +++ b/arch/arm/dts/bcm2835-rpi.dts
> @@ -9,3 +9,10 @@
> reg = <0x0 0x0>;
> };
> };
> +&sdhci {
> + status = "okay";
> +};
> +
> +&sdhost {
> + status = "disabled";
> +};
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: C28E E6B9 0263 95CF 8FAF 08FA 34AD CD00 7221 5CC6 ***
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card
2017-12-06 15:12 [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card Roland Hieber
2017-12-06 15:17 ` Lucas Stach
2017-12-06 16:06 ` Alexander Dahl
@ 2017-12-07 15:19 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2017-12-07 15:19 UTC (permalink / raw)
To: Roland Hieber; +Cc: barebox, Alexander Dahl, Roland Hieber
On Wed, Dec 06, 2017 at 04:12:33PM +0100, Roland Hieber wrote:
> From: Roland Hieber <rohieb@rohieb.name>
>
> Kernel commit a19adf8d86e822eba502486524127595372c85f6 [0] changed the
> RPi1 device tree from &sdhci to &sdhost, which was imported in barebox
> commit d14b844b08635c717fb52a294ed8d6872e260315. It seems that barebox
> does not have a driver for brcm,bcm2835-sdhost (yet), which resulted in
> barebox unable to boot from SD card. However, the driver for
> brcm,bcm2835-sdhci worked fine in the past.
>
> Although the upstream change was made for good reasons, the simplest
> change for barebox for now is to revert to using &sdhci and disable
> &sdhost.
>
> Thanks to Alexander Dahl for raising this issue on the DistroKit
> mailing list!
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a19adf8d86e822eba502486524127595372c85f6
>
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
> arch/arm/dts/bcm2835-rpi.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/dts/bcm2835-rpi.dts b/arch/arm/dts/bcm2835-rpi.dts
> index 0095f58a3c..ab2d6dff64 100644
> --- a/arch/arm/dts/bcm2835-rpi.dts
> +++ b/arch/arm/dts/bcm2835-rpi.dts
> @@ -9,3 +9,10 @@
> reg = <0x0 0x0>;
> };
> };
> +&sdhci {
> + status = "okay";
> +};
> +
> +&sdhost {
> + status = "disabled";
> +};
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread