mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1
Date: Tue, 12 Dec 2017 07:50:23 +0100	[thread overview]
Message-ID: <20171212065023.lm3byrk22lc2lflu@pengutronix.de> (raw)
In-Reply-To: <73ee3115-bff4-7a0f-e8b0-cc14db2d1b86@rempel-privat.de>

On Mon, Dec 11, 2017 at 06:53:25AM +0100, Oleksij Rempel wrote:
> Am 09.12.2017 um 17:54 schrieb Antony Pavlov:
> > On Sat,  9 Dec 2017 10:59:38 +0100
> > Oleksij Rempel <linux@rempel-privat.de> wrote:
> > 
> >> This product can be found here:
> >> https://dptechnics.com/en/products/dpt-module-v1.html
> >>
> >> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> >> ---
> >>  arch/mips/Makefile                                 |  1 +
> >>  arch/mips/boards/dptechnics-dpt-module/Makefile    |  1 +
> >>  arch/mips/boards/dptechnics-dpt-module/board.c     |  8 ++
> >>  .../include/board/board_pbl_start.h                | 20 +++++
> >>  arch/mips/configs/dptechnics-dpt-module_defconfig  | 89 ++++++++++++++++++++++
> >>  arch/mips/dts/ar9331-dptechnics-dpt-module.dts     | 31 ++++++++
> >>  arch/mips/mach-ath79/Kconfig                       |  7 ++
> >>  7 files changed, 157 insertions(+)
> >>  create mode 100644 arch/mips/boards/dptechnics-dpt-module/Makefile
> >>  create mode 100644 arch/mips/boards/dptechnics-dpt-module/board.c
> >>  create mode 100644 arch/mips/boards/dptechnics-dpt-module/include/board/board_pbl_start.h
> >>  create mode 100644 arch/mips/configs/dptechnics-dpt-module_defconfig
> >>  create mode 100644 arch/mips/dts/ar9331-dptechnics-dpt-module.dts
> >>
> >> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> >> index dd5ceea20..b965a9c17 100644
> >> --- a/arch/mips/Makefile
> >> +++ b/arch/mips/Makefile
> >> @@ -79,6 +79,7 @@ machine-$(CONFIG_MACH_MIPS_AR231X)	:= ar231x
> >>  board-$(CONFIG_BOARD_NETGEAR_WG102)	:= netgear-wg102
> >>  
> >>  machine-$(CONFIG_MACH_MIPS_ATH79)	:= ath79
> >> +board-$(CONFIG_BOARC_DPTECHNICS_DPT_MODULE)	:= dptechnics-dpt-module
> >>  board-$(CONFIG_BOARD_TPLINK_MR3020)	:= tplink-mr3020
> >>  board-$(CONFIG_BOARD_TPLINK_WDR4300)	:= tplink-wdr4300
> >>  board-$(CONFIG_BOARD_BLACK_SWIFT)	:= black-swift
> >> diff --git a/arch/mips/boards/dptechnics-dpt-module/Makefile b/arch/mips/boards/dptechnics-dpt-module/Makefile
> >> new file mode 100644
> >> index 000000000..dcfc2937d
> >> --- /dev/null
> >> +++ b/arch/mips/boards/dptechnics-dpt-module/Makefile
> >> @@ -0,0 +1 @@
> >> +obj-y += board.o
> >> diff --git a/arch/mips/boards/dptechnics-dpt-module/board.c b/arch/mips/boards/dptechnics-dpt-module/board.c
> >> new file mode 100644
> >> index 000000000..7ec7ef8a5
> >> --- /dev/null
> >> +++ b/arch/mips/boards/dptechnics-dpt-module/board.c
> >> @@ -0,0 +1,8 @@
> >> +#include <common.h>
> >> +#include <init.h>
> >> +
> >> +static int dummy_init(void)
> >> +{
> >> +	return 0;
> >> +}
> >> +postcore_initcall(dummy_init);
> > 
> > 
> > Do we really need this dummy_init()?
> 
> No, but other ways we need to fix the build system. And right now i have
> no time for that :(

Are you sure you need the dummy_init()? I just gave it a test and I
indeed needed a C file to get it through the linker, but that C file
can equally well be empty.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-12-12  6:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-09  9:59 [PATCH v1 1/4] MIPS: ar9331: add watchdog support Oleksij Rempel
2017-12-09  9:59 ` [PATCH v1 2/4] MIPS: ath79: ar9331: add generic RAM macro Oleksij Rempel
2017-12-09  9:59 ` [PATCH v1 3/4] MIPS: ath79: ar9331: add ar9331_pbl_generic_start macro Oleksij Rempel
2017-12-09  9:59 ` [PATCH v1 4/4] MIPS: add support for DPTechnics DPT-Module v1 Oleksij Rempel
2017-12-09 16:54   ` Antony Pavlov
2017-12-11  5:53     ` Oleksij Rempel
2017-12-12  6:50       ` Sascha Hauer [this message]
2017-12-12  7:00         ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212065023.lm3byrk22lc2lflu@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox