From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] spi: imx: make xchg_single timeout value compatible for older boards
Date: Fri, 15 Dec 2017 08:25:31 +0100 [thread overview]
Message-ID: <20171215072531.zas5242xsgrsctoq@pengutronix.de> (raw)
In-Reply-To: <1513241754-1754-1-git-send-email-akurz@blala.de>
On Thu, Dec 14, 2017 at 09:55:54AM +0100, Alexander Kurz wrote:
> A call of xchg_single will issue the transfer of 24 data bits with a given
> maximum frequency. Since there exist some i.MX based boards with
> spi-max-frequency = <100000>, change the xchg_single timeout to still
> support those boards.
>
> Fixes: 1439cdf7c6fc ("spi: imx: add timeout to xchg_single")
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
> drivers/spi/imx_spi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/spi/imx_spi.c b/drivers/spi/imx_spi.c
> index 7819879..0827de7 100644
> --- a/drivers/spi/imx_spi.c
> +++ b/drivers/spi/imx_spi.c
> @@ -32,8 +32,11 @@
> #include <linux/err.h>
> #include <clock.h>
>
> -/* time to wait for STAT_RR getting set */
> -#define IMX_SPI_RR_TIMEOUT 10000 /* ns */
> +/*
> + * time to wait for STAT_RR getting set, should allow the transfer
> + * of 24 bits at spi-max-frequency of 100kHz
> + */
> +#define IMX_SPI_RR_TIMEOUT 250000 /* ns */
>
> struct imx_spi {
> struct spi_master master;
> --
> 2.1.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-12-15 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 8:55 Alexander Kurz
2017-12-15 7:25 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215072531.zas5242xsgrsctoq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=akurz@blala.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox