From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings
Date: Fri, 15 Dec 2017 08:49:42 +0100 [thread overview]
Message-ID: <20171215074942.7uptifeszea6r6hc@pengutronix.de> (raw)
In-Reply-To: <1513266675-49103-1-git-send-email-d.schultz@phytec.de>
Hi Daniel,
On Thu, Dec 14, 2017 at 04:51:15PM +0100, Daniel Schultz wrote:
> The 'get_ram_size' function can return false values with 1GB RAMs during
> warm reset. If a not-existing RAM size will be returned, the fallback
> RAM timings get loaded to prevent hangs.
Just continuing with wrong ram size and fallback timing is not really an
option. It doesn't help the user and only changes the bug reports you
get.
Sascha
>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> index b1576ee..5030966 100644
> --- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
> +++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> @@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int sdram, int module_family)
> /* Find the ram size and set up the correct ram timings */
> ramsize = get_ram_size((long *) 0x80000000, SZ_1G);
> timing = get_timings_by_size(module_family, ramsize);
> + /* In case of a failure, load generic ram timings as fallback */
> if (!timing)
> - hang();
> + timing = get_minimal_timings(module_family);
> }
>
> am335x_sdram_init(DDR_IOCTRL, &physom_cmd,
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-12-15 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 15:51 Daniel Schultz
2017-12-15 7:49 ` Sascha Hauer [this message]
2017-12-22 8:09 ` Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215074942.7uptifeszea6r6hc@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=d.schultz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox