From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [RFC PATCH] pwm: add pwm-atmel from Linux kernel 4.14
Date: Fri, 5 Jan 2018 12:19:30 +0100 [thread overview]
Message-ID: <20180105111930.m6l7oklzjevsw7ly@pengutronix.de> (raw)
In-Reply-To: <20180101213332.GA7937@ravnborg.org>
On Mon, Jan 01, 2018 at 10:33:32PM +0100, Sam Ravnborg wrote:
> Following patch is more or less untested.
>
> It is posted to get feedback if this is the right way to
> implement support for pwms in at91sam9263 & friends.
>
> In the kernel there is also a file named pwm-atmel-tcb.
> I dunno which is the better starting point.
Looks good, but I don't know the hardware and can't say what
pwm-atmel-tcb is for.
>
> The patch will recognize pwm0 on the at91sam9263ek board
> (if status = "okay") so it has seen minimal testing.
> But I have yet to utilize any of the pwm's.
>
> While working with this I get the impression that the core
> should know about pwm channels and device_d pointer
> should be part of the core data.
I know it's done like this in Linux. Any good reason to do this in
barebox aswell besides of "do it as in Linux"?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-01-05 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 21:33 Sam Ravnborg
2018-01-05 11:19 ` Sascha Hauer [this message]
2018-01-06 7:29 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105111930.m6l7oklzjevsw7ly@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox