From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: [PATCH 4/4] net: designware: add warning for drvdata
Date: Wed, 10 Jan 2018 09:14:20 +0100 [thread overview]
Message-ID: <20180110081420.10722-4-s.trumtrar@pengutronix.de> (raw)
In-Reply-To: <20180110081420.10722-1-s.trumtrar@pengutronix.de>
Instead of silently using a wrong value, check if drvdata is defined
before use.
Print a warning if there is no drvdata found.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
drivers/net/designware.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index ec20da09b388..862ee2f0463e 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -434,7 +434,11 @@ struct dw_eth_dev *dwc_drv_probe(struct device_d *dev)
if (ret)
return ERR_PTR(ret);
- priv->enh_desc = drvdata->enh_desc;
+ if (drvdata && drvdata->enh_desc)
+ priv->enh_desc = drvdata->enh_desc;
+ else
+ dev_warn(dev, "No drvdata specified\n");
+
if (pdata) {
priv->phy_addr = pdata->phy_addr;
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-01-10 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 8:14 [PATCH 1/4] net: designware: move probe to generic driver Steffen Trumtrar
2018-01-10 8:14 ` [PATCH 2/4] net: add SoCFPGA-specific designware driver Steffen Trumtrar
2018-01-10 8:14 ` [PATCH 3/4] ARM: SoCFPGA: remove emac init code Steffen Trumtrar
2018-01-10 8:14 ` Steffen Trumtrar [this message]
2018-01-11 8:34 ` [PATCH 1/4] net: designware: move probe to generic driver Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110081420.10722-4-s.trumtrar@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox