mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Revert "mci: imx-esdhc: Enable clock"
@ 2018-01-10 16:34 Andrey Smirnov
  2018-01-11  8:44 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-01-10 16:34 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

This reverts commit 61c6c24958934b6b226aa37b3b3a2c089189f52b which is
pretty much a duplicate of:

a97345102 "i.MX: esdhc: Enable host->clk during initialization"

Since we don't need to enable that clock twice reverse the former and
keep the latter.
---
 drivers/mci/imx-esdhc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
index 55e8371dd..b91f94b99 100644
--- a/drivers/mci/imx-esdhc.c
+++ b/drivers/mci/imx-esdhc.c
@@ -630,7 +630,6 @@ static int fsl_esdhc_probe(struct device_d *dev)
 	host->clk = clk_get(dev, "per");
 	if (IS_ERR(host->clk))
 		return PTR_ERR(host->clk);
-	clk_enable(host->clk);
 
 	ret = clk_enable(host->clk);
 	if (ret) {
-- 
2.14.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "mci: imx-esdhc: Enable clock"
  2018-01-10 16:34 [PATCH] Revert "mci: imx-esdhc: Enable clock" Andrey Smirnov
@ 2018-01-11  8:44 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-01-11  8:44 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Wed, Jan 10, 2018 at 08:34:30AM -0800, Andrey Smirnov wrote:
> This reverts commit 61c6c24958934b6b226aa37b3b3a2c089189f52b which is
> pretty much a duplicate of:
> 
> a97345102 "i.MX: esdhc: Enable host->clk during initialization"
> 
> Since we don't need to enable that clock twice reverse the former and
> keep the latter.
> ---
>  drivers/mci/imx-esdhc.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
> index 55e8371dd..b91f94b99 100644
> --- a/drivers/mci/imx-esdhc.c
> +++ b/drivers/mci/imx-esdhc.c
> @@ -630,7 +630,6 @@ static int fsl_esdhc_probe(struct device_d *dev)
>  	host->clk = clk_get(dev, "per");
>  	if (IS_ERR(host->clk))
>  		return PTR_ERR(host->clk);
> -	clk_enable(host->clk);
>  
>  	ret = clk_enable(host->clk);
>  	if (ret) {
> -- 
> 2.14.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-11  8:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 16:34 [PATCH] Revert "mci: imx-esdhc: Enable clock" Andrey Smirnov
2018-01-11  8:44 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox