From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ebioe-00042P-RW for barebox@lists.infradead.org; Wed, 17 Jan 2018 08:11:27 +0000 Date: Wed, 17 Jan 2018 09:11:12 +0100 From: Sascha Hauer Message-ID: <20180117081112.hir6nitsmckvdjw7@pengutronix.de> References: <20180111081531.l4yu7xdxyxrtl7gx@pengutronix.de> <20180115113233.30610-1-pmamonov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180115113233.30610-1-pmamonov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 1/3] lib: parse_area_spec: don't modify *start value if parse failed To: Peter Mamonov Cc: barebox@lists.infradead.org On Mon, Jan 15, 2018 at 02:32:31PM +0300, Peter Mamonov wrote: > Signed-off-by: Peter Mamonov > --- > lib/misc.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/lib/misc.c b/lib/misc.c > index 62ddd6677..1767043d1 100644 > --- a/lib/misc.c > +++ b/lib/misc.c > @@ -79,19 +79,19 @@ EXPORT_SYMBOL(strtoul_suffix); > int parse_area_spec(const char *str, loff_t *start, loff_t *size) > { > char *endp; > - loff_t end; > + loff_t end, _start; > > if (!isdigit(*str)) > return -1; > > - *start = strtoull_suffix(str, &endp, 0); > + _start = strtoull_suffix(str, &endp, 0); > > str = endp; > > if (!*str) { > /* beginning given, but no size, assume maximum size */ > *size = ~0; > - return 0; > + goto success; > } > > if (*str == '-') { > @@ -102,15 +102,19 @@ int parse_area_spec(const char *str, loff_t *start, loff_t *size) > return -1; > } > *size = end - *start + 1; Applied with two little changes: It must be _start above and in another case not visible in the patch. *start is not yet initialized. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox