From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ecT9s-0003Wy-7X for barebox@lists.infradead.org; Fri, 19 Jan 2018 09:40:26 +0000 Date: Fri, 19 Jan 2018 10:40:08 +0100 From: Sascha Hauer Message-ID: <20180119094008.6g6otppxgtqgo3rb@pengutronix.de> References: <20180114212252.29682-1-antonynpavlov@gmail.com> <20180117095314.rwdrslwpnkcwa6ey@pengutronix.de> <20180119122901.d58ed91f24057139b2d4239c@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180119122901.d58ed91f24057139b2d4239c@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 0/7] sandbox: add gpio support with libftdi1 To: Antony Pavlov Cc: barebox@lists.infradead.org On Fri, Jan 19, 2018 at 12:29:01PM +0300, Antony Pavlov wrote: > On Wed, 17 Jan 2018 10:53:14 +0100 > Sascha Hauer wrote: > > > Hi Antony, > > > > On Mon, Jan 15, 2018 at 12:22:45AM +0300, Antony Pavlov wrote: > > > This patch series makes it possible to use FT2232H ACBUS[7:0] > > > pins as gpio pins from sandbox barebox. > > > > > > There are ready-to-use FT2232H-based boards: > > > > > > * FT2232H-56Q Mini-Module (http://www.ftdichip.com/Products/Modules/DevelopmentModules.htm#FT2232H-56_Mini) > > > * FT2232 breakout board (http://dangerousprototypes.com/docs/FT2232_breakout_board) > > > > > > The main goal of adding gpio functionality to sandbox barebox > > > is using it for connecting real i2c and spi devices to sandbox barebox. > > > > I applied the parseopt patches for now since they don't need any further > > discussions. > > > > There are three common parseopt-related patches: > > move parseopt to lib/ > include/parseopt.h: add guard macro > parseopt: introduce parseopt_u16() and parseopt_str() > > Please confirm that you have got all three patches. > > > What puzzles me a bit is that the libftdi gpio controller is > > instantiated from the device tree but configured through the > > commandline. It probably has to be like this since we need the > > device tree for using the gpios. > > Getting FTDI chip vendorID and deviceID from device tree is reasonable. > However hardcoding FTDI chip serialnumber into device tree is not so good idea. > In addition dropping cmdline FTDI options parsing makes parseopt_u16() and parseopt_str() unused. > > I propose add FTDI chip vendorID, deviceID and serial options to device tree > and keep parsing the same options from cmdline so once can override FTDI chip > serial number from cmdline. How would you handle multiple FTDI chips then if you want to make use of more than one at a time? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox