mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 5/8] uimage: fix memory leak in error path
Date: Thu, 25 Jan 2018 08:45:17 +0100	[thread overview]
Message-ID: <20180125074520.10320-6-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20180125074520.10320-1-s.hauer@pengutronix.de>

handle->name is dynamically allocated, so free it in the error path.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reported-by: Stefan Lengfeld <contact@stefanchrist.eu>
---
 common/uimage.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/uimage.c b/common/uimage.c
index b6f0f109ca..e857c11d37 100644
--- a/common/uimage.c
+++ b/common/uimage.c
@@ -202,6 +202,8 @@ again:
 	return handle;
 err_out:
 	close(fd);
+
+	free(handle->name);
 	free(handle);
 	if (IS_BUILTIN(CONFIG_FS_TFTP) && !stat(uimage_tmp, &s))
 		unlink(uimage_tmp);
-- 
2.15.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-01-25  7:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  7:45 [PATCH v2 0/8] Make TFTP detection more convenient Sascha Hauer
2018-01-25  7:45 ` [PATCH 1/8] startup: create /tmp Sascha Hauer
2018-01-25  7:45 ` [PATCH 2/8] fs: implement is_tftp_fs() Sascha Hauer
2018-01-25  7:45 ` [PATCH 3/8] libfile: implement make_temp Sascha Hauer
2018-01-25  7:45 ` [PATCH 4/8] libfile: implement a function to cache a file Sascha Hauer
2018-01-25  7:45 ` Sascha Hauer [this message]
2018-01-25  7:45 ` [PATCH 6/8] uimage: Use is_tftp_fs() and cache_file() to ease TFTP workaround Sascha Hauer
2018-01-25  7:45 ` [PATCH 7/8] fs/uimagefs: " Sascha Hauer
2018-01-25  7:45 ` [PATCH 8/8] fs: remove now unused function can_lseek_backward() Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125074520.10320-6-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox