From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1efBgG-0004OY-0H for barebox@lists.infradead.org; Fri, 26 Jan 2018 21:37:05 +0000 Date: Fri, 26 Jan 2018 22:36:51 +0100 From: Sascha Hauer Message-ID: <20180126213651.nz7jslj4tkb4aewb@pengutronix.de> References: <20180126192644.5434-1-s.hauer@pengutronix.de> <20180126204632.GA3317@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180126204632.GA3317@ravnborg.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/2] Make finding fixup nodes more robust To: Sam Ravnborg Cc: Barebox List Hi Sam, On Fri, Jan 26, 2018 at 09:46:32PM +0100, Sam Ravnborg wrote: > Hi Sasha. > > On Fri, Jan 26, 2018 at 08:26:42PM +0100, Sascha Hauer wrote: > > Recently the node names in i.MX6 device tree files have changed. The > > leading zeroes were removed from the addresses. With this a newer > > barebox doesn't find the nodes to fixup in an old device tree and > > an older barebox doesn't find the nodes in a new device tree. To > > fix this we create new names of the nodes based on things that hopefully > > don't change: We iterate up to a node which is MMIO space mappable > > and get a name that starts with "[adr]". For the remaining parts of > > a node we add "" when the hierarchy level has a "reg" property > > and only as last fallback we add "{nodename}" in curly brackets. > > This name is safe against node name changes and also against adding > > a new hierarchy level in the device tree (when for example a bus level > > is added). > I think I was bitten by something similar while toying with display > timings. > > So I think commands/of_display_timings.c would benefit > from a conversion to this new scheme too - as well as the mtd stuff > in of/partition.c of/partition.c is fixed in this series. I haven't looked around what else could benefit from this. Could you try it for the display timing? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox