mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] fs: Fix memory leak in mount()
Date: Mon, 29 Jan 2018 20:05:45 +0100	[thread overview]
Message-ID: <20180129190545.GA29726@ravnborg.org> (raw)
In-Reply-To: <20180129072459.gnpmuyowbnzdebwo@pengutronix.de>

Hi Sasha.

...
> > No check for PTR_ERR after calling canonalize_path()
> > 
> > unlink()
> > No check for PTR_ERR after call to canonalize_dir()
> > 
> > readlink()
> > No check for PTR_ERR after call to canonalize_dir()
> 
> Yes, the result should be checked.
> 
> > 
> > I can create patch for these - but I cannot do any thrustworthy testing.
> > And for the canonalize() I am uncertain if the check is requied.
> > Let me know your preference and I will take care.
> 
> Patches would be very welcomed. Thanks Sam.

Thanks for the confirmation. Will get back to this in a few weeks.
Heading for vacation in a few days, so not time right now.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-01-29 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 19:42 Sascha Hauer
2018-01-26 21:10 ` Sam Ravnborg
2018-01-29  7:24   ` Sascha Hauer
2018-01-29 19:05     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129190545.GA29726@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox