From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1
Date: Tue, 30 Jan 2018 08:13:16 +0100 [thread overview]
Message-ID: <20180130071316.cvizrambsdp6amnr@pengutronix.de> (raw)
In-Reply-To: <20180130070509.33fle5vsktlkkoqx@pengutronix.de>
On Tue, Jan 30, 2018 at 08:05:09AM +0100, Sascha Hauer wrote:
> On Mon, Jan 29, 2018 at 02:04:09PM +0100, Daniel Schultz wrote:
> > do_ubiupdatevol can either return 0 or the ioctl return value. This is
> > not in conformity with the other ubi comannds return values.
> >
> > Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> > ---
> > commands/ubi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks
I meant I Applied 1 & 2.
Sascha
>
> Sascha
>
> >
> > diff --git a/commands/ubi.c b/commands/ubi.c
> > index 5e27584..de5633c 100644
> > --- a/commands/ubi.c
> > +++ b/commands/ubi.c
> > @@ -82,7 +82,7 @@ error:
> > close(fd_vol);
> > error_img:
> > close(fd_img);
> > - return ret;
> > + return ret ? 1 : 0;
> > }
> >
> >
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-01-30 7:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 13:04 Daniel Schultz
2018-01-29 13:04 ` [PATCH 2/3] ARM: configs: am335x_defconfig: Reorder configs Daniel Schultz
2018-01-29 13:04 ` [PATCH 3/3] drivers: mtd: nand: omap: Return stat value Daniel Schultz
2018-01-30 7:11 ` Sascha Hauer
2018-02-15 12:51 ` Daniel Schultz
2018-02-16 7:56 ` Sascha Hauer
2018-02-23 15:53 ` Daniel Schultz
2018-01-30 7:05 ` [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1 Sascha Hauer
2018-01-30 7:13 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130071316.cvizrambsdp6amnr@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=d.schultz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox