From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] net: designware: add missing headers
Date: Mon, 5 Feb 2018 08:23:24 +0100 [thread overview]
Message-ID: <20180205072324.xap3xxejr6elc674@pengutronix.de> (raw)
In-Reply-To: <20180130154013.8446-1-l.stach@pengutronix.de>
On Tue, Jan 30, 2018 at 04:40:12PM +0100, Lucas Stach wrote:
> As the eth_device and mii_bus structs are allocated inside the
> dw_eth_dev struct a forward declaration isn't enough.
>
> Fixes: c1f902841ce3 (net: designware: move probe to generic driver)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/net/designware.h | 3 +--
> drivers/net/designware_generic.c | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/designware.h b/drivers/net/designware.h
> index c9dc27a59474..4a99fa2aa60b 100644
> --- a/drivers/net/designware.h
> +++ b/drivers/net/designware.h
> @@ -20,8 +20,7 @@
> #ifndef __DESIGNWARE_ETH_H
> #define __DESIGNWARE_ETH_H
>
> -struct eth_device;
> -struct mii_bus;
> +#include <net.h>
>
> struct dw_eth_dev {
> struct eth_device netdev;
> diff --git a/drivers/net/designware_generic.c b/drivers/net/designware_generic.c
> index 0e5b9c067b6b..29269deac9e9 100644
> --- a/drivers/net/designware_generic.c
> +++ b/drivers/net/designware_generic.c
> @@ -22,6 +22,7 @@
> */
>
> #include <common.h>
> +#include <init.h>
> #include "designware.h"
>
> static struct dw_eth_drvdata dwmac_370a_drvdata = {
> --
> 2.15.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-02-05 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:40 Lucas Stach
2018-01-30 15:40 ` [PATCH 2/2] reset: add missing stub for reset_control_get Lucas Stach
2018-02-05 7:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205072324.xap3xxejr6elc674@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox