From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eib8T-0005yL-BI for barebox@lists.infradead.org; Mon, 05 Feb 2018 07:24:19 +0000 Date: Mon, 5 Feb 2018 08:24:05 +0100 From: Sascha Hauer Message-ID: <20180205072405.z4flefs7om4qd26q@pengutronix.de> References: <20180130200221.12785-1-linux@rempel-privat.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180130200221.12785-1-linux@rempel-privat.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] net: phy: ar8327: fix ar8327n_reg_read To: Oleksij Rempel Cc: barebox@lists.infradead.org On Tue, Jan 30, 2018 at 09:02:21PM +0100, Oleksij Rempel wrote: > Actual read value was lost and only by accident worked properly. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/phy/ar8327.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/drivers/net/phy/ar8327.c b/drivers/net/phy/ar8327.c > index a0b10021d..e9ac3d49e 100644 > --- a/drivers/net/phy/ar8327.c > +++ b/drivers/net/phy/ar8327.c > @@ -83,7 +83,7 @@ static u32 ar8327n_reg_read(struct phy_device *phydev, u32 reg_addr) > reg_word_addr++; > phy_addr = 0x10 | ((reg_word_addr >> 5) & 0x7); /* bit7-5 of reg address */ > phy_reg = (u8) (reg_word_addr & 0x1f); /* bit4-0 of reg address */ > - reg_val = (u32) mdiobus_read(phydev->bus, phy_addr, phy_reg); > + tmp_val = (u32) mdiobus_read(phydev->bus, phy_addr, phy_reg); > reg_val |= (tmp_val << 16); > > return reg_val; > -- > 2.14.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox