From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] commands: i2c_write: enable raw write to address
Date: Wed, 14 Feb 2018 09:19:06 +0300 [thread overview]
Message-ID: <20180214091906.c73556ec3657ac331603485b@gmail.com> (raw)
In-Reply-To: <20180213081943.cj2ty4e2u746ntja@pengutronix.de>
On Tue, 13 Feb 2018 09:19:43 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Feb 09, 2018 at 02:22:24PM +0300, Antony Pavlov wrote:
> > On Fri, 9 Feb 2018 09:36:36 +0100
> > Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > > Hi Antony,
> > >
> > > On Thu, Feb 08, 2018 at 10:48:56AM +0300, Antony Pavlov wrote:
> > > > Sometimes for communication with a simple I2C devices
> > > > (e.g. PCF8574 or TM1650) it's necessary to send only
> > > > one data byte into the I2C device.
> > > > Current i2c_write command makes this impossible because
> > > > you can't just pass 'device address' and 'register number'
> > > > (or 'device address' and 'one data byte') to the command.
> > > > You always have to pass all three parameters:
> > > > 'device address', 'register number' and 'data'.
> > > >
> > > > This commit fixes the problem.
> > > >
> > > > Sample usage:
> > > >
> > > > barebox@barebox sandbox:/ i2c_write -a 0x24 0x01
> > > >
> > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > > ---
> > > > commands/i2c.c | 8 ++++++--
> > > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > Looks good to me.
> > >
> > > I applied this one despite the [RFC] tag. If for some reason you want to
> > > resend this, feel free to do so, but otherwise consider this applied.
> >
> > Thanks!
> >
> > The patch is short, it's understandable and it fixes the problem.
> > I prefere to apply this patch as is.
> >
> > I see some inconsistency in drivers/i2c/i2c.c.
> > We have i2c_master_send() and i2c_write_reg() functions.
> > These functions are intended to make similar work but they are
> > written in very different style. I suppose that we can rewrite
> > i2c_master_send() (e.g. drop FIXME) and make i2c_write_reg()
> > work on top of i2c_master_send(). Any comments?
>
> Rewrite i2c_master_send()? Do you mean rewrite i2c_write_reg() instead?
You are right, of course I propose rewrite i2c_write_reg() (there is no
FIXME comment inside i2c_master_send()).
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-02-14 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 7:48 Antony Pavlov
2018-02-09 8:36 ` Sascha Hauer
2018-02-09 11:22 ` Antony Pavlov
2018-02-13 8:19 ` Sascha Hauer
2018-02-14 6:19 ` Antony Pavlov [this message]
2018-02-16 7:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214091906.c73556ec3657ac331603485b@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox