From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1emat1-0001gz-GU for barebox@lists.infradead.org; Fri, 16 Feb 2018 07:56:53 +0000 Date: Fri, 16 Feb 2018 08:56:39 +0100 From: Sascha Hauer Message-ID: <20180216075639.yenwl6sdlhqgvwqj@pengutronix.de> References: <1517231051-12129-1-git-send-email-d.schultz@phytec.de> <1517231051-12129-3-git-send-email-d.schultz@phytec.de> <20180130071158.urvefxgjl3lvmfwd@pengutronix.de> <21faa0a6-6514-0020-cec6-6f8af09a9c4c@phytec.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <21faa0a6-6514-0020-cec6-6f8af09a9c4c@phytec.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] drivers: mtd: nand: omap: Return stat value To: Daniel Schultz Cc: barebox@lists.infradead.org On Thu, Feb 15, 2018 at 01:51:26PM +0100, Daniel Schultz wrote: > Hi Sascha, > > > On 01/30/2018 08:11 AM, Sascha Hauer wrote: > > On Mon, Jan 29, 2018 at 02:04:11PM +0100, Daniel Schultz wrote: > > > The read page function should return the total count of flipped bits, > > > otherwise the caller always thinks no bitflip occured. > > > > > > Signed-off-by: Daniel Schultz > > > --- > > > drivers/mtd/nand/nand_omap_gpmc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c > > > index e18ce63..38f4960 100644 > > > --- a/drivers/mtd/nand/nand_omap_gpmc.c > > > +++ b/drivers/mtd/nand/nand_omap_gpmc.c > > > @@ -712,7 +712,7 @@ static int omap_gpmc_read_page_bch_rom_mode(struct mtd_info *mtd, > > > else > > > mtd->ecc_stats.corrected += stat; > > > - return 0; > > > + return stat; > > > } > > I'm afraid this is not enough. read_page should return the maximum > > number of bitflips in any ECC step. You first have to change > > omap_correct_bch() so that it returns this number. > ahh, we worked on this problem a half year ago and it seems like three > patches are missing upstream: > > http://lists.infradead.org/pipermail/barebox/2017-June/030385.html > http://lists.infradead.org/pipermail/barebox/2017-June/030384.html > http://lists.infradead.org/pipermail/barebox/2017-June/030355.html Oh, I see. It seems I have either forgotten to merge them or I have waited for feedback. Could you create a series for all missing patches including your new patch and resend it, provided it works as expected of course? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox